Paths

Table of Contentst

Differential D47878

MAC: syscalls: mac_label_copyin(): 32-bit compatibility
ClosedPublic
Actions

Authored by olce on Dec 3 2024, 2:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 10:05 AM

	Unknown Object (File)
	Thu, Jan 2, 9:40 AM

	Unknown Object (File)
	Fri, Dec 27, 11:16 AM

	Unknown Object (File)
	Fri, Dec 27, 11:00 AM

	Unknown Object (File)
	Fri, Dec 27, 5:43 AM

	Unknown Object (File)
	Dec 17 2024, 10:58 AM

	Unknown Object (File)
	Dec 16 2024, 4:53 PM

	Unknown Object (File)
	Dec 15 2024, 9:02 PM

View All 11 Files

Subscribers

Details

Reviewers

emaste
bapt
brooks

Commits

rG731dc8994cc8: MAC: syscalls: mac_label_copyin(): 32-bit compatibility
rG3bdc5ba2ac76: MAC: syscalls: mac_label_copyin(): 32-bit compatibility

Summary

A step on the way to support 32-bit compatibility for MAC-related system
calls. Needed by the upcoming setcred() system call.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Dec 3 2024, 2:54 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 3 2024, 2:54 PM

olce requested review of this revision.Dec 3 2024, 2:54 PM

Harbormaster completed remote builds in B60926: Diff 147400.Dec 3 2024, 2:55 PM

olce added a parent revision: D46905: MAC: syscalls: Split mac_set_proc() into reusable pieces.Dec 3 2024, 2:57 PM

olce added inline comments.Dec 3 2024, 2:59 PM

sys/security/mac/mac_syscalls.c
154–159	Well, sometimes it's enough to just upload some diff to get a problem back... Bracketing test for `COMPAT_FREEBSD32` is missing here, will add.

brooks added a subscriber: brooks.Dec 3 2024, 5:56 PM

brooks added inline comments.

sys/security/mac/mac_syscalls.c
98	Why `_int`? Maybe `_impl`?
sys/security/mac/mac_syscalls.h
27	This must be named `struct mac32` to support freebsd32 system call stub generation. I'd also be tempted to forward declare it here and keep the real definition in mac_syscalls.c.

brooks added a child revision: D47618: New setcred() system call and associated MAC hooks.Dec 3 2024, 6:06 PM

Apply brooks@'s request and suggestion.

Harbormaster completed remote builds in B60950: Diff 147456.Dec 4 2024, 12:00 PM

olce added inline comments.Dec 4 2024, 12:00 PM

sys/security/mac/mac_syscalls.c
98	`_int` for "internal". Renamed it to `_impl`.

brooks accepted this revision.Dec 4 2024, 4:29 PM

This revision is now accepted and ready to land.Dec 4 2024, 4:29 PM

Closed by commit rG3bdc5ba2ac76: MAC: syscalls: mac_label_copyin(): 32-bit compatibility (authored by olce). · Explain WhyDec 16 2024, 2:46 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG3bdc5ba2ac76: MAC: syscalls: mac_label_copyin(): 32-bit compatibility.

olce added a commit: rG731dc8994cc8: MAC: syscalls: mac_label_copyin(): 32-bit compatibility.Thu, Jan 16, 6:09 PM

Revision Contents
Changeset List

Path

Size

sys/

security/

mac/

7 lines

50 lines

Diff 148034

sys/security/mac/mac_syscalls.h

Loading...

sys/security/mac/mac_syscalls.c

Loading...