Page MenuHomeFreeBSD

MAC/do: Remove PR_METHOD_REMOVE method
ClosedPublic

Authored by olce on Nov 15 2024, 5:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 6, 12:40 PM
Unknown Object (File)
Mon, Jan 6, 8:18 AM
Unknown Object (File)
Mon, Jan 6, 12:43 AM
Unknown Object (File)
Fri, Jan 3, 1:53 AM
Unknown Object (File)
Mon, Dec 30, 2:24 PM
Unknown Object (File)
Fri, Dec 27, 11:19 AM
Unknown Object (File)
Thu, Dec 12, 6:37 PM
Unknown Object (File)
Dec 8 2024, 5:35 PM

Details

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
It isn't really needed, since common jail code destroys jail OSD storage
at jail destruction (via osd_jail_exit()), triggering our destructor
dealloc_osd(). Leveraging this mechanism is arguably even better as it
causes deallocation to always happen without the 'allprison_lock' lock.

While here, make the static definition of 'methods' top-level, renaming
it to 'osd_methods'.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Nov 15 2024, 5:06 PM
This revision is now accepted and ready to land.Nov 19 2024, 7:59 AM
sys/security/mac_do/mac_do.c
448

Should the const qualifier be dropped?

sys/security/mac_do/mac_do.c
448

What for? Jail methods are not supposed to be dynamically changed.

I may have guessed why you're asking this, and if so the answer is here: D46886.

sys/security/mac_do/mac_do.c
448

Ah yes, Nice!

olce marked 2 inline comments as done.Nov 26 2024, 2:22 PM
This revision was automatically updated to reflect the committed changes.