Page MenuHomeFreeBSD
Differential D47581

libc: indicate existing functions in POSIX 2024
ClosedPublic
Actions

Authored by emaste on Nov 14 2024, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 12:25 PM
Unknown Object (File)
Fri, Jan 10, 7:14 AM
Unknown Object (File)
Thu, Jan 9, 11:56 PM
Unknown Object (File)
Wed, Jan 1, 1:05 PM
Unknown Object (File)
Tue, Dec 31, 11:59 AM
Unknown Object (File)
Mon, Dec 30, 12:06 PM
Unknown Object (File)
Sun, Dec 29, 12:07 PM
Unknown Object (File)
Sat, Dec 28, 11:25 AM
View All 16 Files
Subscribers
brooks
kib

Details

Reviewers
imp
brooks
Commits
rG098ed26bf456: libc: indicate existing functions that are POSIX 2024
rGdfa0ac74c2fb: libc: indicate existing functions that are POSIX 2024

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Nov 14 2024, 7:51 PM
emaste created this revision.
imp accepted this revision.Nov 14 2024, 11:37 PM
This revision is now accepted and ready to land.Nov 14 2024, 11:37 PM
brooks accepted this revision.Nov 14 2024, 11:42 PM
brooks added a subscriber: brooks.

Looks generally good. I think it's OK to tag getentropy as compliant even if it's not quite yet.

lib/libc/gen/getentropy.3
73

It looks like our implementation doesn't quite conform in that we don't define {GETENTROPY_MAX} (seemingly 256 from a glance at the code.

emaste added inline comments.Nov 15 2024, 2:31 AM
lib/libc/gen/getentropy.3
73

fair enough - I will leave this one out for now and we can change it when we fix that up -- it looks like we also return EIO instead of EINVAL

Closed by commit rGdfa0ac74c2fb: libc: indicate existing functions that are POSIX 2024 (authored by emaste). · Explain WhyNov 15 2024, 2:33 AM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGdfa0ac74c2fb: libc: indicate existing functions that are POSIX 2024.
kib added a subscriber: kib.Nov 15 2024, 3:55 AM

Also _Fork()

emaste added a commit: rG098ed26bf456: libc: indicate existing functions that are POSIX 2024.Nov 21 2024, 12:46 AM

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
6 lines
stdio/
5 lines
6 lines
stdlib/
3 lines
4 lines
string/
6 lines

Diff 146469

View Options

lib/libc/gen/getentropy.3

Loading...
View Options

lib/libc/stdio/mktemp.3

Loading...
View Options

lib/libc/stdio/printf.3

Loading...
View Options

lib/libc/stdlib/getenv.3

Loading...
View Options

lib/libc/stdlib/reallocarray.3

Loading...
View Options

lib/libc/string/memmem.3

Loading...