Differential D47581

libc: indicate existing functions in POSIX 2024
ClosedPublic
Actions

Authored by emaste on Nov 14 2024, 7:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 1, 1:05 PM

	Unknown Object (File)
	Tue, Dec 31, 11:59 AM

	Unknown Object (File)
	Mon, Dec 30, 12:06 PM

	Unknown Object (File)
	Sun, Dec 29, 12:07 PM

	Unknown Object (File)
	Sat, Dec 28, 11:25 AM

	Unknown Object (File)
	Fri, Dec 27, 12:30 PM

	Unknown Object (File)
	Dec 7 2024, 9:02 PM

	Unknown Object (File)
	Dec 7 2024, 7:47 AM

View All 13 Files

Subscribers

Details

Reviewers

imp
brooks

Commits

rG098ed26bf456: libc: indicate existing functions that are POSIX 2024
rGdfa0ac74c2fb: libc: indicate existing functions that are POSIX 2024

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 14 2024, 7:51 PM

emaste created this revision.

imp accepted this revision.Nov 14 2024, 11:37 PM

This revision is now accepted and ready to land.Nov 14 2024, 11:37 PM

Looks generally good. I think it's OK to tag getentropy as compliant even if it's not quite yet.

lib/libc/gen/getentropy.3
73 ↗	(On Diff #146469)	It looks like our implementation doesn't quite conform in that we don't define {GETENTROPY_MAX} (seemingly 256 from a glance at the code.

emaste added inline comments.Nov 15 2024, 2:31 AM

lib/libc/gen/getentropy.3
73 ↗	(On Diff #146469)	fair enough - I will leave this one out for now and we can change it when we fix that up -- it looks like we also return EIO instead of EINVAL

Closed by commit rGdfa0ac74c2fb: libc: indicate existing functions that are POSIX 2024 (authored by emaste). · Explain WhyNov 15 2024, 2:33 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGdfa0ac74c2fb: libc: indicate existing functions that are POSIX 2024.

Also _Fork()

emaste added a commit: rG098ed26bf456: libc: indicate existing functions that are POSIX 2024.Nov 21 2024, 12:46 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdio/

5 lines

6 lines

stdlib/

3 lines

4 lines

string/

6 lines

Diff 146488

lib/libc/stdio/mktemp.3

Loading...

lib/libc/stdio/printf.3

Loading...

lib/libc/stdlib/getenv.3

Loading...

lib/libc/stdlib/reallocarray.3

Loading...

lib/libc/string/memmem.3

Loading...