swap_pager: Ensure that swapoff puts swapped-in pages in page queues
ClosedPublic
Actions

Authored by markj on Tue, Nov 12, 3:02 PM.

Details

Reviewers

kib
alc
dougm

Commits

rGd11d407aee48: swap_pager: Ensure that swapoff puts swapped-in pages in page queues

Summary

Readahead/behind pages are handled by the swap pager, but the get_pages
caller is responsible for putting fetched pages into queues (or wiring
them beforehand).

Reported by: pho

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Tue, Nov 12, 3:02 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Nov 12, 3:02 PM

markj requested review of this revision.Tue, Nov 12, 3:02 PM

Harbormaster completed remote builds in B60502: Diff 146320.Tue, Nov 12, 3:02 PM

Is this related to the KASSERT that was recently added to vm_object_terminate_single_page?

In D47526#1084075, @alc wrote:

Is this related to the KASSERT that was recently added to vm_object_terminate_single_page?

Yes, Peter was able to trigger the assertion using a swapoff test.

kib accepted this revision.Tue, Nov 12, 11:21 PM

This revision is now accepted and ready to land.Tue, Nov 12, 11:21 PM

alc accepted this revision.Wed, Nov 13, 6:45 AM

dougm accepted this revision.Wed, Nov 13, 8:11 AM

Closed by commit rGd11d407aee48: swap_pager: Ensure that swapoff puts swapped-in pages in page queues (authored by markj). · Explain WhyWed, Nov 13, 2:15 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGd11d407aee48: swap_pager: Ensure that swapoff puts swapped-in pages in page queues.

Revision Contents
Changeset List

Path

Size

sys/

vm/

swap_pager.c

1 line

Diff 146354

View Options

swap_pager: Ensure that swapoff puts swapped-in pages in page queuesClosedPublicActions