riscv: enable allwinner RTC
ClosedPublic
Actions

Authored by mhorne on Nov 11 2024, 5:19 PM.

Details

Reviewers

manu
andrew

Commits

rG9ddd516b8862: riscv: enable allwinner RTC

Summary

For the Allwinner D1 (Nehza) SBC.

This RTC driver is also a clock provider, which registers two fixed
clocks. In all the devices we currently support, the names of the clocks
are present in the "clock-output-names" property of the device tree.
This is not the case for the D1 DTS, as this property does not appear in
upstream. Therefore the clock definitions are statically assigned a
name, which is overridden when specified.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Nov 11 2024, 5:19 PM

Herald added a reviewer: andrew. · View Herald TranscriptNov 11 2024, 5:19 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.Nov 11 2024, 5:19 PM

Harbormaster completed remote builds in B60488: Diff 146283.Nov 11 2024, 5:19 PM

mhorne mentioned this in D35221: riscv: support Allwinner D1 clock controllers.Nov 11 2024, 5:23 PM

@manu This is the first of several changes enabling Allwinner drivers on the riscv platform (probably not all coming today). It suggests that we might move these sources to a more common place (out of arm subdir), but I do not really see any reason this must happen first.

julien.cassette_gmail.com added a subscriber: julien.cassette_gmail.com.Nov 11 2024, 5:43 PM

In D47514#1083739, @mhorne wrote:

@manu This is the first of several changes enabling Allwinner drivers on the riscv platform (probably not all coming today). It suggests that we might move these sources to a more common place (out of arm subdir), but I do not really see any reason this must happen first.

Sure, that's why I started moving a lot of other drivers too in the past.

This revision is now accepted and ready to land.Nov 11 2024, 6:12 PM

Closed by commit rG9ddd516b8862: riscv: enable allwinner RTC (authored by mhorne). · Explain WhyNov 16 2024, 7:04 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG9ddd516b8862: riscv: enable allwinner RTC.

Unfortunately, the assumption about "In all the devices we currently support, the clock names in the "clock-output-names" property" is clearly incorrect. The documented binding for the A10/A20 does not allow any of these clocks. so this breaks every single A10/A20 board...

Additionally, the required and maximum number of items in the clock-output names depends on the platform, so comparing fixed to 3 doesn't look right either.

In D47514#1122729, @mmel wrote:

Unfortunately, the assumption about "In all the devices we currently support, the clock names in the "clock-output-names" property" is clearly incorrect. The documented binding for the A10/A20 does not allow any of these clocks. so this breaks every single A10/A20 board...

Additionally, the required and maximum number of items in the clock-output names depends on the platform, so comparing fixed to 3 doesn't look right either.

Yes, my handling was a little clumsy here, as also reported https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285054.

I will revert for now, to consider the best way to handle this.

The fixed comparison to 3 was an existing assumption of the driver.

mhorne added a reverting change: rG3816452ecac6: Revert "riscv: enable allwinner RTC".Tue, Mar 4, 3:26 PM