Page MenuHomeFreeBSD

periodic: set _localbase in periodic scripts when not set in main script
ClosedPublic

Authored by otis on Nov 8 2024, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 5:00 AM
Unknown Object (File)
Tue, Jan 21, 9:50 PM
Unknown Object (File)
Tue, Jan 14, 2:10 PM
Unknown Object (File)
Mon, Jan 6, 1:50 PM
Unknown Object (File)
Mon, Jan 6, 10:25 AM
Unknown Object (File)
Mon, Jan 6, 6:57 AM
Unknown Object (File)
Sun, Jan 5, 11:23 PM
Unknown Object (File)
Jan 4 2025, 1:20 PM

Details

Summary

Set _localalbase for usage in periodic scripts in case it has not
already been set from within periodic(8) main script.

Reported by: gahr, otis

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60964
Build 57848: arc lint + arc unit

Event Timeline

otis requested review of this revision.Nov 8 2024, 1:41 PM
otis created this revision.
This revision is now accepted and ready to land.Nov 11 2024, 9:45 AM

Works for me!

However, this addition essentially is a duplication of the _localbase logic already present in /usr/sbin/periodic, which is (a) taking _localbase from sysctl and (b) providing a fall-back default just in case. As periodic(8), in some sense, implements a scripting facility similar to rc(8), my feeling is that it's more adequate to implement it along rc(8)'s lines, which is (a) setting _localbase from the sysctl in the main script /etc/rc, and (b) supplying a default for _localbase in /etc/defaults/rc.conf as fallback. Admittedly that's a bit of nitpicking to some extent.

Set _localbase earlier from within /etc/defaults/periodic.conf

This revision now requires review to proceed.Dec 4 2024, 8:40 PM
markj added a subscriber: markj.
markj added inline comments.
usr.sbin/periodic/periodic.conf
18

I'd prefix this with an underscore so that it's less likely to collide with some user-added identifiers.

420

Unrelated whitespace change.

This revision is now accepted and ready to land.Fri, Jan 17, 6:16 PM