vm_reserv: Introduce vm_reserv_populate_range
Needs ReviewPublic
Actions

Authored by bnovkov on Fri, Oct 18, 5:47 PM.

Details

Reviewers

alc
markj
kib

Summary

This patch adds a routine for populating a range of pages within a reservation.
Instead of repeatedly calling vm_reserv_populate, this routine uses bit_nset to populate the bitmap in one go and updates the reservation's partpopq state only once.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bnovkov created this revision.Fri, Oct 18, 5:47 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 18, 5:47 PM

bnovkov requested review of this revision.Fri, Oct 18, 5:47 PM

bnovkov added a parent revision: D47180: vm_reserv: Refactor vm_reserv_populate.

bnovkov added a child revision: D47048: vm_reserv: Introduce vm_reserv_alloc_npages.

kib added inline comments.Fri, Oct 18, 10:13 PM

sys/vm/vm_reserv.c
630	Either use `__FUNCTION__` or `__func__` consistently, please. `__func__` is better because it is standard.
644	Does it make sense to assert that no bits in range are set, before setting them? Otherwise this update might be too optimistic.

alc added inline comments.Fri, Oct 18, 10:31 PM

sys/vm/vm_reserv.c
641–642	This needs to be within a loop. Multiple pages may need to have their psind updated. For example, the range being populated may span multiple 64 KB pages within a 2 MB reservation.
644	This check exists within the caller.
732–733	Call it here.
839–840	And, call it here too.

Adress @kib 's and @alc 's comments:

vm_reserv_populate_range should now properly update psinds for SUBLEVEL-sized superpages
Replaced two 'for loop + vm_reserv_populate' constructs with vm_reserv_populate_range

bnovkov marked 4 inline comments as done.Sat, Oct 19, 6:38 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_reserv.c

42 lines

Diff 145169

View Options

vm_reserv: Introduce vm_reserv_populate_rangeNeeds ReviewPublicActions