Differential D47014

mountd(8): parsecred(): Remove comment on non-existent bug
ClosedPublic
Actions

Authored by olce on Oct 8 2024, 1:47 PM.

Tags

None

Referenced Files

	F107351787: D47014.diff
	Sun, Jan 12, 9:58 PM

	Unknown Object (File)
	Thu, Dec 19, 1:10 PM

	Unknown Object (File)
	Mon, Dec 16, 6:58 PM

	Unknown Object (File)
	Dec 9 2024, 1:08 AM

	Unknown Object (File)
	Nov 22 2024, 5:38 PM

	Unknown Object (File)
	Nov 22 2024, 12:08 PM

	Unknown Object (File)
	Nov 18 2024, 8:43 AM

	Unknown Object (File)
	Nov 7 2024, 2:48 PM

View All 14 Files

Subscribers

Details

Reviewers

Commits

rG0b011b5cddb5: mountd(8): parsecred(): Remove comment on non-existent bug

Summary

'name' can never be NULL, as it is equal to 'names' and 'namelist',
which was passed by do_cred() only if the actual parameter wasn't NULL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59845
Build 56730: arc lint + arc unit

Event Timeline

olce created this revision.Oct 8 2024, 1:47 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 8 2024, 1:47 PM

olce requested review of this revision.Oct 8 2024, 1:47 PM

Harbormaster completed remote builds in B59845: Diff 144489.Oct 8 2024, 1:47 PM

olce added a parent revision: D47013: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials.Oct 8 2024, 1:48 PM

olce added a child revision: D47015: mountd(8): parsecred(): Re-order operations for clarity.

Looks ok to me.

This revision is now accepted and ready to land.Oct 16 2024, 3:30 PM

Closed by commit rG0b011b5cddb5: mountd(8): parsecred(): Remove comment on non-existent bug (authored by olce). · Explain WhyMon, Dec 16, 2:46 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG0b011b5cddb5: mountd(8): parsecred(): Remove comment on non-existent bug.

Revision Contents
Changeset List

Path

Size

usr.sbin/

mountd/

1 line

Diff 144489

usr.sbin/mountd/mountd.c

Loading...