Page MenuHomeFreeBSD
Differential D47009

env: Check the status of stdout.
ClosedPublic
Actions

Authored by des on Tue, Oct 8, 10:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 7:59 AM
Unknown Object (File)
Tue, Oct 22, 12:29 PM
Unknown Object (File)
Mon, Oct 21, 4:24 PM
Unknown Object (File)
Tue, Oct 15, 6:30 AM
Unknown Object (File)
Sun, Oct 13, 1:33 PM
Unknown Object (File)
Wed, Oct 9, 7:51 AM
Unknown Object (File)
Wed, Oct 9, 4:57 AM
Unknown Object (File)
Tue, Oct 8, 7:40 PM
View All 9 Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rGc2d93a803ace: env: Check the status of stdout.
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59833
Build 56718: arc lint + arc unit

Event Timeline

des created this revision.Tue, Oct 8, 10:07 AM
Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 8, 10:07 AM
des requested review of this revision.Tue, Oct 8, 10:07 AM
Harbormaster completed remote builds in B59832: Diff 144468.Tue, Oct 8, 10:07 AM
des updated this revision to Diff 144469.Tue, Oct 8, 10:07 AM
des added a parent revision: D47008: env: Add an option to change the directory..

Add test

Harbormaster completed remote builds in B59833: Diff 144469.Tue, Oct 8, 10:09 AM
markj added a subscriber: markj.Tue, Oct 8, 11:41 AM
markj added inline comments.
usr.bin/env/tests/env_test.sh
127

The rest of the file puts opening braces on their own lines.

133

Does it make sense to sleep for a bit first, to make sure that the other end of the pipe has time to close? Maybe I'm missing something, but this looks like it might fail only sometimes.

des added inline comments.Tue, Oct 8, 1:44 PM
usr.bin/env/tests/env_test.sh
127

Yeah sorry this was copy-pasted from asa.

133

It works 100% of the time, we use the exact same procedure several other places (including asa which is where I copied this from). Timing doesn't matter because none of the output is consumed and the kernel doesn't buffer it.

markj accepted this revision as: markj.Tue, Oct 8, 1:45 PM
This revision is now accepted and ready to land.Tue, Oct 8, 1:45 PM
des updated this revision to Diff 144493.Tue, Oct 8, 1:48 PM

style

This revision now requires review to proceed.Tue, Oct 8, 1:48 PM
Harbormaster completed remote builds in B59849: Diff 144493.Tue, Oct 8, 1:48 PM
des marked 2 inline comments as done.Tue, Oct 8, 1:49 PM
markj accepted this revision as: markj.Tue, Oct 8, 4:59 PM
This revision is now accepted and ready to land.Tue, Oct 8, 4:59 PM
Closed by commit rGc2d93a803ace: env: Check the status of stdout. (authored by des). · Explain WhyTue, Oct 8, 5:02 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGc2d93a803ace: env: Check the status of stdout..
des mentioned this in rG08e8554c4a39: env: Add a handful of test cases..Tue, Oct 15, 6:30 AM
des mentioned this in rG80c9caa46b1e: env: Add a handful of test cases..

Revision Contents
Changeset List

PathSize
usr.bin/
env/
2 lines
tests/
15 lines

Diff 144469

View Options

usr.bin/env/env.c

Loading...
View Options

usr.bin/env/tests/env_test.sh

Loading...