Paths

Table of Contentst

Differential D47009

env: Check the status of stdout.
ClosedPublic
Actions

Authored by des on Oct 8 2024, 10:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 18, 2:47 AM

	Unknown Object (File)
	Fri, Jan 17, 11:56 AM

	Unknown Object (File)
	Thu, Jan 16, 2:15 PM

	Unknown Object (File)
	Dec 30 2024, 5:14 AM

	Unknown Object (File)
	Dec 4 2024, 3:22 PM

	Unknown Object (File)
	Nov 29 2024, 5:40 AM

	Unknown Object (File)
	Nov 21 2024, 7:45 AM

	Unknown Object (File)
	Nov 20 2024, 8:59 AM

View All 24 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGc2d93a803ace: env: Check the status of stdout.

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Oct 8 2024, 10:07 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 8 2024, 10:07 AM

des requested review of this revision.Oct 8 2024, 10:07 AM

Harbormaster completed remote builds in B59832: Diff 144468.Oct 8 2024, 10:07 AM

Add test

Harbormaster completed remote builds in B59833: Diff 144469.Oct 8 2024, 10:09 AM

markj added a subscriber: markj.Oct 8 2024, 11:41 AM

markj added inline comments.

usr.bin/env/tests/env_test.sh
134	The rest of the file puts opening braces on their own lines.
140	Does it make sense to sleep for a bit first, to make sure that the other end of the pipe has time to close? Maybe I'm missing something, but this looks like it might fail only sometimes.

des added inline comments.Oct 8 2024, 1:44 PM

usr.bin/env/tests/env_test.sh
134	Yeah sorry this was copy-pasted from `asa`.
140	It works 100% of the time, we use the exact same procedure several other places (including `asa` which is where I copied this from). Timing doesn't matter because none of the output is consumed and the kernel doesn't buffer it.

markj accepted this revision as: markj.Oct 8 2024, 1:45 PM

This revision is now accepted and ready to land.Oct 8 2024, 1:45 PM

style

This revision now requires review to proceed.Oct 8 2024, 1:48 PM

Harbormaster completed remote builds in B59849: Diff 144493.Oct 8 2024, 1:48 PM

des marked 2 inline comments as done.Oct 8 2024, 1:49 PM

markj accepted this revision as: markj.Oct 8 2024, 4:59 PM

This revision is now accepted and ready to land.Oct 8 2024, 4:59 PM

Closed by commit rGc2d93a803ace: env: Check the status of stdout. (authored by des). · Explain WhyOct 8 2024, 5:02 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGc2d93a803ace: env: Check the status of stdout..

des mentioned this in rG08e8554c4a39: env: Add a handful of test cases..Oct 15 2024, 6:30 AM

des mentioned this in rG80c9caa46b1e: env: Add a handful of test cases..

Revision Contents
Changeset List

Path

Size

usr.bin/

env/

2 lines

tests/

17 lines

Diff 144501

usr.bin/env/env.c

Loading...

usr.bin/env/tests/env_test.sh

Loading...