Page MenuHomeFreeBSD

vm_page: Track number of allocated NOFREE pages
AbandonedPublic

Authored by bnovkov on Oct 7 2024, 3:25 PM.
Tags
None
Referenced Files
F114873765: D46979.diff
Thu, Apr 17, 11:32 PM
F114827373: D46979.diff
Thu, Apr 17, 8:34 AM
Unknown Object (File)
Wed, Apr 16, 1:21 AM
Unknown Object (File)
Feb 12 2025, 4:03 AM
Unknown Object (File)
Feb 12 2025, 1:48 AM
Unknown Object (File)
Feb 9 2025, 10:00 PM
Unknown Object (File)
Jan 13 2025, 7:44 AM
Unknown Object (File)
Jan 12 2025, 4:53 PM
Subscribers

Details

Reviewers
markj
alc
kib

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59810
Build 56695: arc lint + arc unit

Event Timeline

It's more a matter of taste than anything I guess, but I'd merge this with the previous patch. They are small enough that they can be reviewed as one patch, and it feels a bit silly to have a change which introduces a counter but doesn't use it. I almost pointed that out in the other revision before I saw this one, since it looked like an unintentional omission.

sys/vm/vm_page.c
2596

This can be done outside the lock; counter(9) is implemented using per-CPU counters that do not require explicit synchronization.

It's more a matter of taste than anything I guess, but I'd merge this with the previous patch. They are small enough that they can be reviewed as one patch, and it feels a bit silly to have a change which introduces a counter but doesn't use it. I almost pointed that out in the other revision before I saw this one, since it looked like an unintentional omission.

Sure, I was on the fence about that from the beginning, I'll go ahead and merge it into the parent review.