Page MenuHomeFreeBSD
Differential D46846

sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND
ClosedPublic
Actions

Authored by christos on Sep 29 2024, 2:09 PM.
Tags
None
Referenced Files
F102914623: D46846.diff
Mon, Nov 18, 4:56 PM
Unknown Object (File)
Sat, Nov 16, 7:50 PM
Unknown Object (File)
Fri, Nov 15, 9:50 AM
Unknown Object (File)
Fri, Nov 8, 10:52 PM
Unknown Object (File)
Tue, Nov 5, 8:52 AM
Unknown Object (File)
Fri, Nov 1, 9:18 PM
Unknown Object (File)
Thu, Oct 31, 2:42 PM
Unknown Object (File)
Wed, Oct 30, 6:26 AM
View All 14 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG7a7ba76aa6f0: sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND
rGaaf84d0e9683: sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Sep 29 2024, 2:09 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 29 2024, 2:09 PM
christos requested review of this revision.Sep 29 2024, 2:09 PM
Harbormaster completed remote builds in B59654: Diff 143901.Sep 29 2024, 2:09 PM
dev_submerge.ch accepted this revision.Sep 29 2024, 4:43 PM
This revision is now accepted and ready to land.Sep 29 2024, 4:43 PM
markj accepted this revision.Sep 30 2024, 8:10 AM
emaste added a comment.Sep 30 2024, 2:34 PM

Should we clarify this case in sbuf(9), either with the SBUF_AUTOEXTEND description or in the RETURN VALUES section for sbuf_new?

Across the tree there's a mix of checking for NULL with SBUF_AUTOEXTEND and not checking, sometimes both cases in the same file (sys/dev/acpica/acpi.c).

Closed by commit rGaaf84d0e9683: sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND (authored by christos). · Explain WhyOct 18 2024, 8:45 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGaaf84d0e9683: sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND.
christos added a commit: rG7a7ba76aa6f0: sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND.Sun, Oct 20, 11:22 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
midi/
6 lines
pcm/
5 lines

Diff 145095

View Options

sys/dev/sound/midi/midi.c

Loading...
View Options

sys/dev/sound/pcm/sndstat.c

Loading...