Page MenuHomeFreeBSD

tests: kern: add some porch(1)-based tty tests
ClosedPublic

Authored by kevans on Sep 27 2024, 5:11 AM.
Tags
None
Referenced Files
F102720399: D46806.id143781.diff
Sat, Nov 16, 8:16 AM
Unknown Object (File)
Sat, Nov 9, 3:32 AM
Unknown Object (File)
Mon, Oct 28, 10:30 AM
Unknown Object (File)
Fri, Oct 25, 8:24 PM
Unknown Object (File)
Oct 16 2024, 12:19 PM
Unknown Object (File)
Oct 12 2024, 10:59 PM
Unknown Object (File)
Oct 5 2024, 3:31 AM
Unknown Object (File)
Oct 4 2024, 7:27 PM
Subscribers

Details

Summary

If sysutils/porch is installed, we'll do some basic testing of tty
behavior. The existing tests primarily cover ICANON-related processing
and corner cases that have been fixed somewhat recently, but I
anticipate growing this out a bit in due time.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Could you please demo the test program (attach the kyua html report)?

Could you please demo the test program (attach the kyua html report)?

Neat, I had no idea that kyua had a report-html command.

I uploaded the report here: https://people.freebsd.org/~kevans/porch-results/

archive.tar in that directory packages the directory for convenience. IMO it leaves a little bit to be desired, I would've kinda liked to see test names to attribute each result to, but maybe it does if they fail/skip.

Could you please demo the test program (attach the kyua html report)?

Neat, I had no idea that kyua had a report-html command.

I uploaded the report here: https://people.freebsd.org/~kevans/porch-results/

archive.tar in that directory packages the directory for convenience. IMO it leaves a little bit to be desired, I would've kinda liked to see test names to attribute each result to, but maybe it does if they fail/skip.

Timing data:

Start time: No tests run
End time: No tests run
Duration: 0.000s

Hmmm.. that seems a bit suspicious. Is there a way to confirm that the tests have run somehow?

Could you please demo the test program (attach the kyua html report)?

Neat, I had no idea that kyua had a report-html command.

I uploaded the report here: https://people.freebsd.org/~kevans/porch-results/

archive.tar in that directory packages the directory for convenience. IMO it leaves a little bit to be desired, I would've kinda liked to see test names to attribute each result to, but maybe it does if they fail/skip.

Timing data:

Start time: No tests run
End time: No tests run
Duration: 0.000s

Hmmm.. that seems a bit suspicious. Is there a way to confirm that the tests have run somehow?

Odd. Ok, how about:

root@aarch64-dev:/usr/tests/sys/kern/tty# kyua test -k Kyuafile 
test_canon:main  ->  passed  [4.083s]
test_canon_fullbuf:main  ->  passed  [0.009s]
test_ncanon:main  ->  passed  [0.019s]
test_recanon:main  ->  passed  [0.023s]

Results file id is usr_tests_sys_kern_tty.20241020-044415-526690
Results saved to /root/.kyua/store/results.usr_tests_sys_kern_tty.20241020-044415-526690.db

4/4 passed (0 failed)
root@aarch64-dev:/usr/tests/sys/kern/tty# kyua report 
===> Summary
Results read from /root/.kyua/store/results.usr_tests_sys_kern_tty.20241020-044415-526690.db
Test cases: 4 total, 0 skipped, 0 expected failures, 0 broken, 0 failed
Total time: 4.135s
This revision is now accepted and ready to land.Sun, Oct 20, 4:11 PM