Differential D46799

Build BSD diff3 if GNU diff3 is disabled.
ClosedPublic
Actions

Authored by des on Sep 26 2024, 9:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 2:35 PM

	Unknown Object (File)
	Sun, Oct 27, 8:01 AM

	Unknown Object (File)
	Oct 12 2024, 5:08 AM

	Unknown Object (File)
	Oct 10 2024, 11:36 PM

	Unknown Object (File)
	Oct 10 2024, 11:29 PM

	Unknown Object (File)
	Oct 10 2024, 11:28 PM

	Unknown Object (File)
	Oct 10 2024, 11:28 PM

	Unknown Object (File)
	Oct 4 2024, 4:10 PM

View All 17 Files

Subscribers

Details

Reviewers

thj
bapt
kevans

Group Reviewers

Commits

rG2201f7c49f11: Build BSD diff3 if GNU diff3 is disabled.

Summary

MFC after: 3 weeks
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Sep 26 2024, 9:30 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 26 2024, 9:30 PM

des requested review of this revision.Sep 26 2024, 9:30 PM

Harbormaster completed remote builds in B59608: Diff 143766.Sep 26 2024, 9:30 PM

kevans accepted this revision.Sep 27 2024, 12:31 AM

This revision is now accepted and ready to land.Sep 27 2024, 12:31 AM

While this review is ok I think we can only enable it when the etcupdate testsuite passes without error which is not the case yet, I 3 tests gnu diff3 manage to merge while bsd diff3 considers conflits: always_test:main, fbsdid_test:main, preworld_test:main, tests_test:main

@bapt thank you for the test cases, this gives me something to work towards.

Closed by commit rG2201f7c49f11: Build BSD diff3 if GNU diff3 is disabled. (authored by des). · Explain WhyOct 2 2024, 3:56 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG2201f7c49f11: Build BSD diff3 if GNU diff3 is disabled..

emaste mentioned this in D46878: Retire GNU diff3.Oct 2 2024, 4:40 PM

Revision Contents
Changeset List

Path

Size

tools/

build/

mk/

OptionalObsoleteFiles.inc

5 lines

options/

WITHOUT_GNU_DIFF

5 lines

2 lines

usr.bin/

3 lines

Diff 144129

tools/build/mk/OptionalObsoleteFiles.inc

Loading...

tools/build/options/WITHOUT_GNU_DIFF

Loading...

tools/build/options/WITH_GNU_DIFF

Loading...

usr.bin/Makefile

Loading...