Page MenuHomeFreeBSD
Differential D46705

pf: fold pf_test_fragment() into pf_test_rule()
ClosedPublic
Actions

Authored by kp on Sep 19 2024, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 3:45 AM
Unknown Object (File)
Thu, Jan 30, 1:34 AM
Unknown Object (File)
Fri, Jan 24, 5:43 PM
Unknown Object (File)
Fri, Jan 24, 5:41 PM
Unknown Object (File)
Fri, Jan 24, 10:26 AM
Unknown Object (File)
Thu, Jan 23, 6:47 PM
Unknown Object (File)
Dec 24 2024, 9:14 PM
Unknown Object (File)
Nov 13 2024, 7:02 PM
View All 31 Files
Subscribers
ae
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG288bec2b2bd1: pf: fold pf_test_fragment() into pf_test_rule()
Summary

Reduces code and fixes a bunch of bugs with fragment handling not being in sync
with the rest of the ruleset.

Much feedback from mpf, bluhm & markus
Thanks to Tony Sarendal for help with testing

ok bluhm; various previous versions ok henning, claudio, mpf, markus

Note that while this changes the order of src addr/src port/dst addr/dst port
skips this doesn't actually affect the kernel/userspace ABI. The kernel always
recalculates skip steps.

Obtained from: OpenBSD, mcbride <mcbride@openbsd.org>, 04c69899a7
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59535
Build 56422: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
4 lines
2 lines
sys/
net/
5 lines
netpfil/
pf/
4 lines
448 lines

Diff 143494

View Options

sbin/pfctl/parse.y

Loading...
View Options

sbin/pfctl/pfctl_optimize.c

Loading...
View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf.h

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...