Page MenuHomeFreeBSD

pf: fold pf_test_fragment() into pf_test_rule()
Needs ReviewPublic

Authored by kp on Thu, Sep 19, 8:24 PM.
Tags
None
Referenced Files
F95803859: D46705.id143494.diff
Sun, Sep 22, 5:25 PM
Unknown Object (File)
Sat, Sep 21, 5:44 PM
Unknown Object (File)
Fri, Sep 20, 3:24 AM

Details

Reviewers
None
Group Reviewers
network
pfsense
Summary

Reduces code and fixes a bunch of bugs with fragment handling not being in sync
with the rest of the ruleset.

Much feedback from mpf, bluhm & markus
Thanks to Tony Sarendal for help with testing

ok bluhm; various previous versions ok henning, claudio, mpf, markus

Note that while this changes the order of src addr/src port/dst addr/dst port
skips this doesn't actually affect the kernel/userspace ABI. The kernel always
recalculates skip steps.

Obtained from: OpenBSD, mcbride <mcbride@openbsd.org>, 04c69899a7
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59535
Build 56422: arc lint + arc unit