sound: Remove KASSERT from vchan_setnew()
ClosedPublic
Actions

Authored by christos on Sep 5 2024, 5:03 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGe1eaa312d592: sound: Remove KASSERT from vchan_setnew()
rG998de46c5145: sound: Remove KASSERT from vchan_setnew()

Summary

This check is not really useful, and can in fact break things, if
sysctl_dev_pcm_vchans() calls vchan_setnew() with a value that will not
satisfy the KASSERT condition.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59318
Build 56205: arc lint + arc unit

Event Timeline

christos created this revision.Sep 5 2024, 5:03 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 5 2024, 5:03 PM

christos requested review of this revision.Sep 5 2024, 5:03 PM

Harbormaster completed remote builds in B59318: Diff 142981.Sep 5 2024, 5:03 PM

christos added a child revision: D46520: sound: Retire SND_MAXVCHANS.Sep 5 2024, 5:04 PM

christos mentioned this in D46520: sound: Retire SND_MAXVCHANS.Sep 5 2024, 5:24 PM

dev_submerge.ch accepted this revision.Sep 13 2024, 6:34 PM

This revision is now accepted and ready to land.Sep 13 2024, 6:34 PM

emaste accepted this revision.Sep 13 2024, 6:57 PM

Closed by commit rG998de46c5145: sound: Remove KASSERT from vchan_setnew() (authored by christos). · Explain WhyFri, Oct 18, 8:45 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG998de46c5145: sound: Remove KASSERT from vchan_setnew().

christos added a commit: rGe1eaa312d592: sound: Remove KASSERT from vchan_setnew().Sun, Oct 20, 11:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

vchan.c

3 lines

Diff 142981

View Options

sound: Remove KASSERT from vchan_setnew()ClosedPublicActions