sound: Remove KASSERT from vchan_setnew()
AcceptedPublic
Actions

Authored by christos on Thu, Sep 5, 5:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 18, 4:34 AM

	Unknown Object (File)
	Tue, Sep 17, 12:50 AM

	Unknown Object (File)
	Wed, Sep 11, 12:51 PM

	Unknown Object (File)
	Tue, Sep 10, 5:30 AM

	Unknown Object (File)
	Sun, Sep 8, 10:16 PM

	Unknown Object (File)
	Sun, Sep 8, 5:38 PM

	Unknown Object (File)
	Sat, Sep 7, 11:39 PM

	Unknown Object (File)
	Sat, Sep 7, 8:05 PM

View All 14 Files

Subscribers

imp

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

This check is not really useful, and can in fact break things, if
sysctl_dev_pcm_vchans() calls vchan_setnew() with a value that will not
satisfy the KASSERT condition.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59318
Build 56205: arc lint + arc unit

Event Timeline

christos created this revision.Thu, Sep 5, 5:03 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 5, 5:03 PM

christos requested review of this revision.Thu, Sep 5, 5:03 PM

Harbormaster completed remote builds in B59318: Diff 142981.Thu, Sep 5, 5:03 PM

christos added a child revision: D46520: sound: Retire SND_MAXVCHANS.Thu, Sep 5, 5:04 PM

christos mentioned this in D46520: sound: Retire SND_MAXVCHANS.Thu, Sep 5, 5:24 PM

dev_submerge.ch accepted this revision.Fri, Sep 13, 6:34 PM

This revision is now accepted and ready to land.Fri, Sep 13, 6:34 PM

emaste accepted this revision.Fri, Sep 13, 6:57 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

vchan.c

3 lines

Diff 142981

View Options

sound: Remove KASSERT from vchan_setnew()AcceptedPublicActions