Page MenuHomeFreeBSD

ifconfig: Add an allmulti verb
ClosedPublic

Authored by markj on Sep 3 2024, 5:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 4:58 AM
Unknown Object (File)
Fri, Nov 15, 3:57 AM
Unknown Object (File)
Fri, Nov 15, 1:42 AM
Unknown Object (File)
Sat, Nov 9, 11:16 AM
Unknown Object (File)
Sat, Nov 9, 11:14 AM
Unknown Object (File)
Sat, Nov 9, 11:13 AM
Unknown Object (File)
Sat, Nov 9, 11:13 AM
Unknown Object (File)
Thu, Nov 7, 7:59 PM
Subscribers

Details

Summary

Similar to "promisc", this allows the IFF_ALLMULTI flag to be toggled,
which can be useful for IPv6 neighbour discovery; see PR 233683.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Sep 3 2024, 5:00 PM
glebius added a subscriber: glebius.
glebius added inline comments.
sbin/ifconfig/ifconfig.8
31

Needs to be bumped.

This revision is now accepted and ready to land.Sep 3 2024, 10:44 PM
zlei added a subscriber: zlei.

which can be useful for IPv6 neighbour discovery

@markj I guess you mean help debugging IPv6 ND function ;)

Looks good to me.

I think you need to modify IFF_CANTCHANGE in sys/net/if.h

which can be useful for IPv6 neighbour discovery

@markj I guess you mean help debugging IPv6 ND function ;)

Looks good to me.

The use-case which motivated this is neighbour discover over netmap, where the kernel doesn't know which multicast addresses to subscribe to.

In D46525#1060625, @ae wrote:

I think you need to modify IFF_CANTCHANGE in sys/net/if.h

IMO that is not quite right, per the comments in D46524.

Toggle IFF_PALLMULTI instead of IFF_ALLMULTI, to match IFF_PROMISC handling.

This revision now requires review to proceed.Sep 5 2024, 2:22 PM
This revision is now accepted and ready to land.Sep 5 2024, 4:23 PM

which can be useful for IPv6 neighbour discovery

@markj I guess you mean help debugging IPv6 ND function ;)

Looks good to me.

The use-case which motivated this is neighbour discover over netmap, where the kernel doesn't know which multicast addresses to subscribe to.

I'd support if you can include that in the final commit message :)

In D46525#1060625, @ae wrote:

I think you need to modify IFF_CANTCHANGE in sys/net/if.h

IMO that is not quite right, per the comments in D46524.

which can be useful for IPv6 neighbour discovery

@markj I guess you mean help debugging IPv6 ND function ;)

Looks good to me.

The use-case which motivated this is neighbour discover over netmap, where the kernel doesn't know which multicast addresses to subscribe to.

I'd support if you can include that in the final commit message :)

Thanks for taking a look. Certainly, my original description is basically useless. :(

This revision was automatically updated to reflect the committed changes.