: Conditionally export table of bit names
Needs ReviewPublic
Actions

Authored by jhb on Tue, Apr 22, 3:04 AM.

Details

Reviewers

bz
imp

Summary

Only export the array of string names if _WANT_IFCAP_BIT_NAMES is
defined. Exporting them unconditionally can trigger unused variable
warnings if a consumer doesn't use the array.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63623
Build 60507: arc lint + arc unit

Event Timeline

jhb created this revision.Tue, Apr 22, 3:04 AM

Herald added subscribers: glebius, melifaro, ae. · View Herald TranscriptTue, Apr 22, 3:04 AM

jhb requested review of this revision.Tue, Apr 22, 3:04 AM

Harbormaster completed remote builds in B63623: Diff 154066.Tue, Apr 22, 3:04 AM

jhb added a child revision: D49955: <net/sff8472.h>: Conditionally export table of ID names.Tue, Apr 22, 3:04 AM

jhb mentioned this in D49830: kernel/gcc: turn off -Werror=unused-variable.Tue, Apr 22, 3:05 AM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifconfig_netlink.c

2 lines

sys/

net/

if_strings.h

2 lines

Diff 154066

View Options

sbin/ifconfig/ifconfig_netlink.c