Page MenuHomeFreeBSD

pkgbase: Make src package creation recipes more precise
ClosedPublic

Authored by markj on Aug 19 2024, 3:24 PM.
Tags
None
Referenced Files
F115590124: D46320.diff
Fri, Apr 25, 6:34 PM
Unknown Object (File)
Mon, Apr 21, 7:32 AM
Unknown Object (File)
Sun, Apr 20, 9:29 AM
Unknown Object (File)
Sun, Apr 20, 1:18 AM
Unknown Object (File)
Sat, Apr 19, 6:59 PM
Unknown Object (File)
Thu, Apr 17, 4:18 PM
Unknown Object (File)
Thu, Apr 17, 4:18 PM
Unknown Object (File)
Thu, Apr 17, 4:14 PM
Subscribers

Details

Summary

Just remove the plist created by the respective rule. Otherwise the two
receipes can race with each other.

Fixes: d7d5c9efef03 ("pkgbase: Let source packages be built in parallel")
Reported by: Mark Millard <marklmi@yahoo.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59049
Build 55936: arc lint + arc unit

Event Timeline

markj requested review of this revision.Aug 19 2024, 3:24 PM
This revision is now accepted and ready to land.Aug 19 2024, 3:27 PM

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

Yeah, I'm not sure. -f should ensure that the exit status is 0 if the file doesn't exit.