Page MenuHomeFreeBSD

pkgbase: Make src package creation recipes more precise
ClosedPublic

Authored by markj on Aug 19 2024, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:04 AM
Unknown Object (File)
Sat, Nov 9, 11:04 AM
Unknown Object (File)
Sat, Nov 9, 11:03 AM
Unknown Object (File)
Wed, Nov 6, 6:14 AM
Unknown Object (File)
Tue, Nov 5, 9:33 AM
Unknown Object (File)
Tue, Oct 22, 3:31 PM
Unknown Object (File)
Oct 4 2024, 8:17 PM
Unknown Object (File)
Oct 3 2024, 2:20 PM
Subscribers

Details

Summary

Just remove the plist created by the respective rule. Otherwise the two
receipes can race with each other.

Fixes: d7d5c9efef03 ("pkgbase: Let source packages be built in parallel")
Reported by: Mark Millard <marklmi@yahoo.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Aug 19 2024, 3:24 PM
This revision is now accepted and ready to land.Aug 19 2024, 3:27 PM

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

Yeah, I'm not sure. -f should ensure that the exit status is 0 if the file doesn't exit.