Page MenuHomeFreeBSD
Differential D46315

swap_pager: cleanup pctrie usage
ClosedPublic
Actions

Authored by dougm on Aug 17 2024, 6:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 8:29 AM
Unknown Object (File)
Mon, Oct 21, 1:59 PM
Unknown Object (File)
Mon, Oct 21, 1:58 PM
Unknown Object (File)
Mon, Oct 21, 1:58 PM
Unknown Object (File)
Mon, Oct 21, 1:58 PM
Unknown Object (File)
Mon, Oct 21, 1:45 PM
Unknown Object (File)
Oct 1 2024, 9:55 PM
Unknown Object (File)
Sep 21 2024, 11:15 PM
View All 22 Files
Subscribers
imp
pho

Details

Reviewers
kib
Commits
rG942647057295: swap_pager: clean up pctrie usage
Summary

Separate the meta_transfer and meta_free functions, because one of them may have to release a lock and rebuild the iterator, and the other one does not.

Define helper functions for the various pctrie routines, to hide some of the ugliness.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Aug 17 2024, 6:33 PM
dougm created this revision.
dougm mentioned this in D45627: pctrie: create iterator.Aug 17 2024, 6:38 PM
pho added a subscriber: pho.Aug 17 2024, 6:51 PM
kib accepted this revision.Aug 19 2024, 8:07 AM
This revision is now accepted and ready to land.Aug 19 2024, 8:07 AM
dougm updated this revision to Diff 143136.Sep 9 2024, 8:56 AM
dougm retitled this revision from swap_pager: use pctrie iterators to avoid duplicating searches to swap_pager: cleanup pctrie usage.
dougm edited the summary of this revision. (Show Details)

Discard the iterators, as it seems they aren't being accepted. Keep the rest.

This revision now requires review to proceed.Sep 9 2024, 8:56 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2024, 9:47 PM
Closed by commit rG942647057295: swap_pager: clean up pctrie usage (authored by dougm). · Explain Why
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rG942647057295: swap_pager: clean up pctrie usage.
Herald added a subscriber: imp. · View Herald TranscriptSep 9 2024, 9:47 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
231 lines

Diff 143163

View Options

sys/vm/swap_pager.c

Loading...