Page MenuHomeFreeBSD

lib/libc/aarch64/string: add strlcat SIMD implementation
Needs ReviewPublic

Authored by getz on Aug 12 2024, 10:46 AM.
Tags
None
Referenced Files
F97196114: D46272.id142009.diff
Sat, Sep 28, 3:17 AM
Unknown Object (File)
Mon, Sep 23, 12:49 AM
Unknown Object (File)
Sat, Sep 21, 2:36 PM
Unknown Object (File)
Sat, Sep 21, 4:52 AM
Unknown Object (File)
Sat, Sep 21, 1:44 AM
Unknown Object (File)
Fri, Sep 20, 2:46 AM
Unknown Object (File)
Tue, Sep 17, 10:43 PM
Unknown Object (File)
Tue, Sep 17, 9:04 PM
Subscribers

Details

Reviewers
fuz
emaste
andrew
Summary

This patch requires D46243 as it depends on strlcpy being labeled
__strlcpy.

It's a direct copy from the amd64 string functions using memchr and
strlcpy to implement strlcat.

Test Plan

Passes all tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58989
Build 55876: arc lint + arc unit

Event Timeline

getz requested review of this revision.Aug 12 2024, 10:46 AM

remove manpage update, lets handle that in a separate commit

Could this be made machine independent?

@andrew If we don't have assembly implementations for strlcpy and memchr, it's generally faster to implement this function directly.