Differential D45971

fibs: Suppress the WARNING message for the setups with multiple fibs
ClosedPublic
Actions

Authored by zlei on Jul 14 2024, 2:33 PM.

Tags

None

Referenced Files

	F97864846: D45971.id140874.diff
	Tue, Oct 1, 1:40 PM

	Unknown Object (File)
	Sat, Sep 14, 1:12 PM

	Unknown Object (File)
	Tue, Sep 10, 12:31 AM

	Unknown Object (File)
	Sun, Sep 8, 3:57 PM

	Unknown Object (File)
	Sun, Sep 8, 9:07 AM

	Unknown Object (File)
	Sat, Sep 7, 10:58 PM

	Unknown Object (File)
	Sat, Sep 7, 1:30 PM

	Unknown Object (File)
	Aug 8 2024, 11:27 AM

View All 15 Files

Subscribers

Details

Reviewers

melifaro
markj

Group Reviewers

Commits

rGa48f7a2eb90b: fibs: Suppress the WARNING message for setups with multiple fibs

Summary

Change 2d3982419593 switched net.add_addr_allfibs default to 0. The
warning message is for potential users of the feature. While since all
supported releases have 0 as default, those potential users may have
already gotten the notification, emitting this WARNING every time
increasing the fib number is less useful but rather confusing to other
users. So let's suppress it now.

MFC after: ???

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jul 14 2024, 2:33 PM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptJul 14 2024, 2:33 PM

I'm still thinking if this should be MFCed to stable/14 . I'd prefer to keep stable/13 as is.

markj accepted this revision as: markj.Jul 14 2024, 4:11 PM

This revision is now accepted and ready to land.Jul 14 2024, 4:11 PM

I'm planning to land this change at this weekend. @melifaro Any objections ?

zlei mentioned this in D46204: fibs: Limit the WARNING message to only once when setting up with multiple fibs.Aug 1 2024, 2:52 PM

In D45971#1047966, @zlei wrote:

I'm still thinking if this should be MFCed to stable/14 . I'd prefer to keep stable/13 as is.

Hi, @markj please have a look at the fix D46204 for stable/14 and stable/13 .

Closed by commit rGa48f7a2eb90b: fibs: Suppress the WARNING message for setups with multiple fibs (authored by zlei). · Explain WhyAug 1 2024, 5:51 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGa48f7a2eb90b: fibs: Suppress the WARNING message for setups with multiple fibs.

Revision Contents
Changeset List

Path

Size

sys/

net/

route/

5 lines

Diff 141682

sys/net/route/route_tables.c

Loading...