Page MenuHomeFreeBSD

fibs: Limit the WARNING message to only once when setting up with multiple fibs
ClosedPublic

Authored by zlei on Aug 1 2024, 2:52 PM.
Tags
None
Referenced Files
F102633229: D46204.diff
Fri, Nov 15, 2:39 AM
Unknown Object (File)
Wed, Nov 13, 2:25 AM
Unknown Object (File)
Wed, Nov 6, 10:48 PM
Unknown Object (File)
Wed, Nov 6, 2:40 AM
Unknown Object (File)
Tue, Nov 5, 10:22 AM
Unknown Object (File)
Fri, Oct 18, 11:08 AM
Unknown Object (File)
Thu, Oct 17, 4:59 PM
Unknown Object (File)
Oct 16 2024, 5:16 PM
Subscribers

Details

Summary

Suppressing this warning message has been done in main [1] but no plans
to MFC as the message is still useful for users that upgrade from older
releases. Well emitting this warning message every time increasing the
fib number is confusing for users not for the feature net.add_addr_allfibs,
let's limit it to print only once.

  1. D45971 fibs: Suppress the WARNING message for the setups with multiple fibs

This is a direct commit to stable/14.

PR: 280097
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Aug 1 2024, 2:52 PM

This is direct fix for stable/14 and stable/13. The meta commit message

MFC after:

is not accurate. Should be MFS.

Seems reasonable to me. In general I'd discourage such changes in stable/14, as it's not a bug fix per se, but this is small and not intrusive.

This revision is now accepted and ready to land.Aug 1 2024, 2:54 PM