Page MenuHomeFreeBSD
Differential D45969

sound examples: Add sndstat nvlist example
ClosedPublic
Actions

Authored by christos on Jul 13 2024, 7:22 PM.
Tags
None
Referenced Files
F103019414: D45969.diff
Tue, Nov 19, 9:54 PM
Unknown Object (File)
Mon, Nov 18, 4:06 AM
Unknown Object (File)
Wed, Nov 13, 6:26 PM
Unknown Object (File)
Sat, Nov 9, 2:54 AM
Unknown Object (File)
Mon, Oct 28, 12:27 PM
Unknown Object (File)
Oct 7 2024, 2:03 AM
Unknown Object (File)
Oct 4 2024, 7:46 AM
Unknown Object (File)
Oct 2 2024, 4:32 PM
View All 31 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGb4a9d6c8faf5: sound examples: Add sndstat nvlist example
rGf08ecd24a19b: sound examples: Add sndstat nvlist example
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Test Plan

Test output: https://reviews.freebsd.org/P643

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Jul 13 2024, 7:22 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 13 2024, 7:22 PM
christos requested review of this revision.Jul 13 2024, 7:22 PM
Harbormaster completed remote builds in B58635: Diff 140868.Jul 13 2024, 7:22 PM
christos edited the test plan for this revision. (Show Details)Jul 13 2024, 7:22 PM
dev_submerge.ch added a comment.Jul 14 2024, 7:03 PM

This file should probably also be added to share/examples/Makefile?

christos updated this revision to Diff 140884.Jul 14 2024, 8:29 PM

Update Makefile.

Harbormaster completed remote builds in B58641: Diff 140884.Jul 14 2024, 8:29 PM
dev_submerge.ch accepted this revision.Jul 17 2024, 12:12 AM
This revision is now accepted and ready to land.Jul 17 2024, 12:12 AM
markj added a comment.Jul 21 2024, 4:26 PM

What does the example program actually do? It would be useful to have an explanation somewhere in the file.

christos added a comment.Jul 22 2024, 11:19 AM
In D45969#1049928, @markj wrote:

What does the example program actually do? It would be useful to have an explanation somewhere in the file.

It showcases how the sndstat nvlist interface can be used to extract all the information currently available. The man page already include a basic example section, but I think it's nice to have this program as well which can be run immediately and show how every single field can be fetched.

markj added a comment.Jul 22 2024, 2:02 PM
In D45969#1050053, @christos wrote:
In D45969#1049928, @markj wrote:

What does the example program actually do? It would be useful to have an explanation somewhere in the file.

It showcases how the sndstat nvlist interface can be used to extract all the information currently available. The man page already include a basic example section, but I think it's nice to have this program as well which can be run immediately and show how every single field can be fetched.

Sure, I can figure that out, my point is really that this would be more to a casual reader with some comments and a link to documentation.

Closed by commit rGf08ecd24a19b: sound examples: Add sndstat nvlist example (authored by christos). · Explain WhyJul 27 2024, 11:57 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGf08ecd24a19b: sound examples: Add sndstat nvlist example.
christos added a commit: rGb4a9d6c8faf5: sound examples: Add sndstat nvlist example.Jul 29 2024, 3:36 PM

Revision Contents
Changeset List

PathSize
share/
examples/
3 lines
sound/
206 lines

Diff 141458

View Options

share/examples/Makefile

Loading...
View Options

share/examples/sound/sndstat_nv.c

Loading...