Revert "loader/lua: Remove workaround for command_error"
ClosedPublic
Actions

Authored by imp on Jul 5 2024, 6:23 PM.

Details

Reviewers

kevans
manu

Commits

rG7ffa3b0f69dc: Revert "loader/lua: Remove workaround for command_error"
rG809edb3636a5: Revert "loader/lua: Remove workaround for command_error"

Summary

This reverts commit 552f3072af54820cf1805f712e2567bc1b7f046d.

loader.command_error was added just after 11.2, but appears to not have
been back ported to 11.x. 11.0 was the first lua loader release, so keep
this compat shim until we sort out what to do, but whine about needing
to upgrade.

MFC After: 3 days
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58517
Build 55405: arc lint + arc unit

Event Timeline

imp created this revision.Jul 5 2024, 6:23 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 5 2024, 6:23 PM

Herald added subscribers: dab, andrew_tao173.riddles.org.uk. · View Herald Transcript

imp requested review of this revision.Jul 5 2024, 6:23 PM

Harbormaster completed remote builds in B58517: Diff 140586.Jul 5 2024, 6:23 PM

imp added a parent revision: D45882: Revert "loader/lua: Remove compat shim for loader.lua_path".Jul 5 2024, 6:23 PM

imp added a child revision: D45884: loader: If the boot loader is too old, note it in the menu.

Just revert, kill the other changes.
Commit message locally updated to remove bit about whining, that will be a separate,
future commit.

Harbormaster completed remote builds in B58525: Diff 140598.Jul 5 2024, 8:47 PM

imp added a child revision: D45888: loader: Bump all versions to 3.0.Jul 5 2024, 8:52 PM

imp removed a child revision: D45884: loader: If the boot loader is too old, note it in the menu.

kevans accepted this revision.Jul 9 2024, 8:40 PM

This revision is now accepted and ready to land.Jul 9 2024, 8:40 PM

Closed by commit rG809edb3636a5: Revert "loader/lua: Remove workaround for command_error" (authored by imp). · Explain WhyJul 29 2024, 10:58 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG809edb3636a5: Revert "loader/lua: Remove workaround for command_error".

imp added a commit: rG7ffa3b0f69dc: Revert "loader/lua: Remove workaround for command_error".Aug 1 2024, 2:52 PM

Revision Contents
Changeset List

Path

Size

stand/

lua/

config.lua

7 lines

core.lua

8 lines

Diff 140586

View Options

stand/lua/config.lua