Page MenuHomeFreeBSD
Differential D45882

Revert "loader/lua: Remove compat shim for loader.lua_path"
ClosedPublic
Actions

Authored by imp on Jul 5 2024, 6:23 PM.
Tags
None
Referenced Files
F115577922: D45882.id140597.diff
Fri, Apr 25, 2:15 PM
Unknown Object (File)
Wed, Apr 23, 12:18 PM
Unknown Object (File)
Fri, Apr 18, 2:49 AM
Unknown Object (File)
Mon, Apr 14, 7:28 PM
Unknown Object (File)
Tue, Apr 8, 2:40 AM
Unknown Object (File)
Mon, Apr 7, 4:40 PM
Unknown Object (File)
Feb 25 2025, 10:50 PM
Unknown Object (File)
Feb 22 2025, 2:25 PM
View All 64 Files
Subscribers
andrew_tao173.riddles.org.uk
dab

Details

Reviewers
kevans
manu
Commits
rG598b9677b3e9: Revert "loader/lua: Remove compat shim for loader.lua_path"
rG522a65a8d97a: Revert "loader/lua: Remove compat shim for loader.lua_path"
Summary

This reverts commit ab97d42addae97a389c6f22d6bba62ed954bb8e7.

There's too many people in the field with FreeBSD 12.0 loader.efi that
stubbed their toe on upgrading to 14.1 since they'd not updated
loader.efi. While we sort out that mess, add back this workaround and
also whine the loader is too old. Can revisit after 14.2 maybe.

MFC After: 3 days
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58516
Build 55404: arc lint + arc unit

Event Timeline

imp created this revision.Jul 5 2024, 6:23 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 5 2024, 6:23 PM
Herald added subscribers: dab, andrew_tao173.riddles.org.uk. · View Herald Transcript
imp requested review of this revision.Jul 5 2024, 6:23 PM
imp added a parent revision: D45881: Revert "loader/lua: Remove pager shim".
Harbormaster completed remote builds in B58516: Diff 140585.Jul 5 2024, 6:23 PM
imp added a child revision: D45883: Revert "loader/lua: Remove workaround for command_error".Jul 5 2024, 6:23 PM
imp updated this revision to Diff 140597.Jul 5 2024, 8:47 PM

Just revert, kill the other changes.
Commit message locally updated to remove bit about whining, that will be a separate,
future commit.

Harbormaster completed remote builds in B58524: Diff 140597.Jul 5 2024, 8:47 PM
kevans accepted this revision.Jul 9 2024, 8:40 PM
This revision is now accepted and ready to land.Jul 9 2024, 8:40 PM
Closed by commit rG522a65a8d97a: Revert "loader/lua: Remove compat shim for loader.lua_path" (authored by imp). · Explain WhyJul 29 2024, 10:58 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG522a65a8d97a: Revert "loader/lua: Remove compat shim for loader.lua_path".
imp added a commit: rG598b9677b3e9: Revert "loader/lua: Remove compat shim for loader.lua_path".Aug 1 2024, 2:52 PM

Revision Contents
Changeset List

PathSize
stand/
lua/
10 lines

Diff 140585

View Options

stand/lua/core.lua

Loading...