Page MenuHomeFreeBSD

dhclient: Ignore SIP servers DHCP option defined in RFC 3361
ClosedPublic

Authored by michaelo on Jul 4 2024, 6:13 PM.
Tags
None
Referenced Files
F96221930: D45873.id140555.diff
Tue, Sep 24, 3:08 AM
Unknown Object (File)
Sat, Sep 21, 10:42 PM
Unknown Object (File)
Fri, Sep 20, 10:12 AM
Unknown Object (File)
Wed, Sep 18, 9:42 AM
Unknown Object (File)
Thu, Sep 12, 5:52 PM
Unknown Object (File)
Wed, Sep 11, 4:36 PM
Unknown Object (File)
Sun, Sep 8, 11:32 PM
Unknown Object (File)
Sun, Sep 8, 3:46 PM
Subscribers

Details

Summary

Ignore SIP servers dhcp option to shut up the warning message.
This option is defined in the RFC 3361 and sent from NSD-G1000T router.

PR: 280119

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58498
Build 55386: arc lint + arc unit

Event Timeline

jrm added a subscriber: brooks.

RFC 3361 declares 120 to be the code for the option, and this is doing the same thing as what's done for other unimplemented options, so this seems fine to me too. I'll add @brooks, a src committer who just touched dhclient, to be sure we're not missing something. Please make sure you use git commit --author to attribute Yuichiro NAITO in the commit logs.

This revision is now accepted and ready to land.Jul 4 2024, 6:35 PM
In D45873#1045890, @jrm wrote:

RFC 3361 declares 120 to be the code for the option, and this is doing the same thing as what's done for other unimplemented options, so this seems fine to me too. I'll add @brooks, a src committer who just touched dhclient, to be sure we're not missing something. Please make sure you use git commit --author to attribute Yuichiro NAITO in the commit logs.

Did that already, gave the reporter full credits.

Seems reasonable to me.