Page MenuHomeFreeBSD
Differential D45736

sched_unpin(): assert that curthread was pinned
ClosedPublic
Actions

Authored by kib on Jun 25 2024, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 22, 8:59 PM
Unknown Object (File)
Sat, Sep 21, 5:17 AM
Unknown Object (File)
Wed, Sep 18, 10:37 AM
Unknown Object (File)
Tue, Sep 17, 3:24 PM
Unknown Object (File)
Mon, Sep 9, 2:53 AM
Unknown Object (File)
Sun, Sep 8, 9:05 PM
Unknown Object (File)
Sat, Sep 7, 9:34 AM
Unknown Object (File)
Aug 30 2024, 9:17 AM
View All 20 Files
Subscribers
imp
olce

Details

Reviewers
markj
emaste
imp
olce
Commits
rG7e5574f9e5d9: sched_unpin(): assert that curthread was pinned

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Jun 25 2024, 8:10 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 25 2024, 8:10 PM
kib requested review of this revision.Jun 25 2024, 8:10 PM
kib mentioned this in D45191: amd64: use INVLPGB for kernel pmap invalidations.
markj accepted this revision.Jun 25 2024, 8:21 PM

While here, it would be nice to include sys/kassert.h.

This revision is now accepted and ready to land.Jun 25 2024, 8:21 PM
imp accepted this revision.Jun 25 2024, 8:32 PM
emaste accepted this revision.Jun 25 2024, 8:37 PM
kib added a comment.Jun 25 2024, 9:05 PM
In D45736#1043145, @markj wrote:

While here, it would be nice to include sys/kassert.h.

The file does not include sys/proc.h, which is vital for inline functions. sys/proc.h itself includes sys/systm.h, which includes sys/kassert.h. I am not sure that including kassert.h is useful.

olce accepted this revision.Jun 25 2024, 9:10 PM
olce added a subscriber: olce.

As @markj said, while here, please include sys/assert.h explicitly. It is already due because of sched_userret() above.

markj added a comment.Jun 25 2024, 10:03 PM
In D45736#1043169, @kib wrote:
In D45736#1043145, @markj wrote:

While here, it would be nice to include sys/kassert.h.

The file does not include sys/proc.h, which is vital for inline functions. sys/proc.h itself includes sys/systm.h, which includes sys/kassert.h. I am not sure that including kassert.h is useful.

IMO the header should include proc.h (when _KERNEL is defined) then, but yes, it's probably not too productive to include kassert.h by itself.

Closed by commit rG7e5574f9e5d9: sched_unpin(): assert that curthread was pinned (authored by kib). · Explain WhyJun 26 2024, 7:05 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG7e5574f9e5d9: sched_unpin(): assert that curthread was pinned.

Revision Contents
Changeset List

PathSize
sys/
sys/
1 line

Diff 140239

View Options

sys/sys/sched.h

Loading...