Page MenuHomeFreeBSD

sys: move SAN and COVERAGE options handling to kern.mk
AcceptedPublic

Authored by khng on Jun 11 2024, 10:23 PM.
Tags
None
Referenced Files
F101975605: D45563.diff
Wed, Nov 6, 1:24 AM
Unknown Object (File)
Fri, Oct 18, 1:47 PM
Unknown Object (File)
Sep 8 2024, 6:25 PM
Unknown Object (File)
Sep 8 2024, 5:43 AM
Unknown Object (File)
Sep 8 2024, 1:33 AM
Unknown Object (File)
Sep 7 2024, 9:45 AM
Unknown Object (File)
Aug 31 2024, 2:15 PM
Unknown Object (File)
Aug 31 2024, 2:15 PM
Subscribers

Details

Reviewers
allanjude
markj
Summary

This allows the flags to be picked up more easily when building external
modules.

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60064
Build 56948: arc lint + arc unit

Event Timeline

khng requested review of this revision.Jun 11 2024, 10:23 PM

I think there's some overlap here with D45498. At a glance this seems fine to me.

Updated to adapt to NOSAN's introduction

This seems ok, but the kernel build is complicated and it's hard to be confident in such changes just by reading the diff. Please make sure you test building of all of the *SAN kernels (amd64 and arm64) and look at the build output to verify that -fsanitizer is being specified both for the kernel and for kernel modules.

This revision is now accepted and ready to land.Sat, Oct 19, 12:52 PM