pci(4): unbreak the build
ClosedPublic
Actions

Authored by ngie on Jun 5 2024, 4:22 AM.

Details

Reviewers

jhb
imp
markj
lwhsu
zlei
emaste
allanjude

Commits

rG637ee1391957: pci(4): unbreak the build

Summary

argsp is not defined in generic_pcie_unmap_resource(..). Remove the
parameter passed to bus_generic_unmap_resource(..) as this parameter
is never passed to generic_pcie_unmap_resource(..).

Fixes: 98056127ddfa ("acpi/pci/vmd: Fix a nit with nested resource mapping requests")
Reported by: Jenkins (aarch64, armv6, armv7, etc)

Test Plan

This change built with GENERIC on amd64 and arm64/aarch64.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Jun 5 2024, 4:22 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 5 2024, 4:22 AM

ngie requested review of this revision.Jun 5 2024, 4:22 AM

Harbormaster completed remote builds in B58062: Diff 139483.Jun 5 2024, 4:22 AM

ngie added reviewers: jhb, imp.Jun 5 2024, 4:24 AM

ngie added a reviewer: markj.

ngie edited the summary of this revision. (Show Details)Jun 5 2024, 4:26 AM

ngie edited the test plan for this revision. (Show Details)Jun 5 2024, 4:31 AM

ngie edited the summary of this revision. (Show Details)Jun 5 2024, 4:56 AM

ngie added a reviewer: lwhsu.

It is definitely the right fix.

This revision is now accepted and ready to land.Jun 5 2024, 9:38 AM

emaste accepted this revision.Jun 5 2024, 1:09 PM

allanjude accepted this revision.Jun 5 2024, 1:23 PM

Closed by commit rG637ee1391957: pci(4): unbreak the build (authored by ngie). · Explain WhyJun 5 2024, 1:56 PM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG637ee1391957: pci(4): unbreak the build.

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic.c

2 lines

Diff 139510

View Options

sys/dev/pci/pci_host_generic.c

pci(4): unbreak the buildClosedPublicActions