Page MenuHomeFreeBSD
Differential D45493

pci(4): unbreak the build
ClosedPublic
Actions

Authored by ngie on Jun 5 2024, 4:22 AM.
Tags
None
Referenced Files
F115913130: D45493.diff
Wed, Apr 30, 8:17 AM
Unknown Object (File)
Wed, Apr 23, 11:54 PM
Unknown Object (File)
Sat, Apr 12, 11:34 PM
Unknown Object (File)
Mar 17 2025, 12:27 PM
Unknown Object (File)
Feb 28 2025, 5:26 PM
Unknown Object (File)
Feb 16 2025, 8:56 AM
Unknown Object (File)
Feb 15 2025, 5:58 PM
Unknown Object (File)
Feb 15 2025, 9:09 AM
View All 37 Files
Subscribers
imp
zlei

Details

Reviewers
jhb
imp
markj
lwhsu
zlei
emaste
allanjude
Commits
rG0787c99b477e: pci(4): unbreak the build
rG637ee1391957: pci(4): unbreak the build
Summary

argsp is not defined in generic_pcie_unmap_resource(..). Remove the
parameter passed to bus_generic_unmap_resource(..) as this parameter
is never passed to generic_pcie_unmap_resource(..).

Fixes: 98056127ddfa ("acpi/pci/vmd: Fix a nit with nested resource mapping requests")
Reported by: Jenkins (aarch64, armv6, armv7, etc)

Test Plan

This change built with GENERIC on amd64 and arm64/aarch64.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58062
Build 54950: arc lint + arc unit

Event Timeline

ngie created this revision.Jun 5 2024, 4:22 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 5 2024, 4:22 AM
ngie requested review of this revision.Jun 5 2024, 4:22 AM
Harbormaster completed remote builds in B58062: Diff 139483.Jun 5 2024, 4:22 AM
ngie added reviewers: jhb, imp.Jun 5 2024, 4:24 AM
ngie added a reviewer: markj.
ngie edited the summary of this revision. (Show Details)Jun 5 2024, 4:26 AM
ngie edited the test plan for this revision. (Show Details)Jun 5 2024, 4:31 AM
ngie edited the summary of this revision. (Show Details)Jun 5 2024, 4:56 AM
ngie added a reviewer: lwhsu.
zlei accepted this revision.Jun 5 2024, 9:38 AM
zlei added a subscriber: zlei.

It is definitely the right fix.

This revision is now accepted and ready to land.Jun 5 2024, 9:38 AM
emaste accepted this revision.Jun 5 2024, 1:09 PM
allanjude accepted this revision.Jun 5 2024, 1:23 PM
Closed by commit rG637ee1391957: pci(4): unbreak the build (authored by ngie). · Explain WhyJun 5 2024, 1:56 PM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rG637ee1391957: pci(4): unbreak the build.
jhb added a commit: rG0787c99b477e: pci(4): unbreak the build.Feb 27 2025, 2:18 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
2 lines

Diff 139483

View Options

sys/dev/pci/pci_host_generic.c

Loading...