Page MenuHomeFreeBSD

nvmf: Rescan namespaces after reconnecting
ClosedPublic

Authored by jhb on Jun 2 2024, 6:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 23, 9:29 AM
Unknown Object (File)
Thu, Sep 19, 8:48 PM
Unknown Object (File)
Thu, Sep 19, 3:02 PM
Unknown Object (File)
Thu, Sep 19, 1:55 PM
Unknown Object (File)
Wed, Sep 18, 12:19 PM
Unknown Object (File)
Tue, Sep 10, 2:21 AM
Unknown Object (File)
Mon, Sep 9, 9:13 PM
Unknown Object (File)
Sun, Sep 1, 12:59 AM
Subscribers
None

Details

Summary

In particular, check to see if namespaces have been added or removed
while disconnected.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jun 2 2024, 6:44 PM
jhb created this revision.

Is this a good place to add a brief note about why this is a good idea, either in the commit message or in the code? (If so, I'd lean towards the former).

This revision is now accepted and ready to land.Jun 2 2024, 6:57 PM
In D45461#1036800, @imp wrote:

Is this a good place to add a brief note about why this is a good idea, either in the commit message or in the code? (If so, I'd lean towards the former).

Oh, yeah, I probably should note that a namespace could have been removed or added while we were disconnected in the log message. That's the use case, though after the change to optionally fail I/O's while disconnected it is also needed to "see" existing namespaces after a reconnect. For this commit though in the time sequence it is just the "something changed while disconnected" (which is also how I tested it, using ctladm to add/remove LUNs on the server side while the client was disconnected).

This revision was automatically updated to reflect the committed changes.