Differential D45326

riscv: Don't handle missing kernel L3 pages
ClosedPublic
Actions

Authored by mhorne on May 23 2024, 7:53 PM.

Tags

None

Referenced Files

	F97860403: D45326.diff
	Tue, Oct 1, 1:25 PM

	F97722466: D45326.id139009.diff
	Mon, Sep 30, 11:39 PM

	Unknown Object (File)
	Thu, Sep 19, 9:11 AM

	Unknown Object (File)
	Wed, Sep 18, 1:15 PM

	Unknown Object (File)
	Wed, Sep 18, 1:15 PM

	Unknown Object (File)
	Sat, Sep 14, 10:39 PM

	Unknown Object (File)
	Sun, Sep 8, 11:49 PM

	Unknown Object (File)
	Fri, Sep 6, 1:55 AM

View All 26 Files

Subscribers

Details

Reviewers

markj
br
jrtc27
jhb

Group Reviewers

Commits

rG3ff981587ff8: riscv: Don't handle missing kernel L3 pages

Summary

This code path should never be hit, if it does it means we did not
bootstrap correctly. Turn it into a panic like we do on amd64 and arm64.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 23 2024, 7:53 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2024, 7:53 PM

mhorne requested review of this revision.May 23 2024, 7:53 PM

Harbormaster completed remote builds in B57880: Diff 139009.May 23 2024, 7:53 PM

mhorne added a parent revision: D45325: riscv: adjust physmem reservation.May 23 2024, 7:53 PM

mhorne added a child revision: D45327: riscv: rework page table bootstrap.

I have a vague memory that this was needed at some point, but after digging for a while I can't find it. It'll be pretty obvious if the premise of the commit is wrong, so this seems ok.

This revision is now accepted and ready to land.May 27 2024, 2:07 PM

jhb accepted this revision.Jun 6 2024, 5:24 PM

Closed by commit rG3ff981587ff8: riscv: Don't handle missing kernel L3 pages (authored by mhorne). · Explain WhyJun 14 2024, 6:02 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG3ff981587ff8: riscv: Don't handle missing kernel L3 pages.

Revision Contents
Changeset List

Path

Size

sys/

riscv/

riscv/

43 lines

Diff 139859

sys/riscv/riscv/pmap.c

Loading...