Page MenuHomeFreeBSD
Differential D45319

devmap: eliminate unused arguments
ClosedPublic
Actions

Authored by mhorne on May 23 2024, 7:15 PM.
Tags
None
Referenced Files
F102085024: D45319.diff
Thu, Nov 7, 10:33 AM
Unknown Object (File)
Sat, Oct 19, 1:32 PM
Unknown Object (File)
Sat, Oct 19, 1:12 PM
Unknown Object (File)
Oct 2 2024, 3:00 AM
Unknown Object (File)
Sep 22 2024, 7:02 PM
Unknown Object (File)
Sep 21 2024, 3:56 PM
Unknown Object (File)
Sep 14 2024, 10:47 PM
Unknown Object (File)
Sep 10 2024, 4:41 PM
View All Files
Subscribers
emaste
imp
olce
riscv

Details

Reviewers
andrew
markj
manu
Commits
rG5df74441b35f: devmap: eliminate unused arguments
Summary

The optional 'table' pointer is a legacy part of the interface, which
has been replaced by devmap_register_table()/devmap_add_entry(). The few
in-tree callers have already adapted to this, so it can be removed.

The 'l1pt' argument is already entirely unused within the function.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58054
Build 54942: arc lint + arc unit

Event Timeline

mhorne created this revision.May 23 2024, 7:15 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 23 2024, 7:15 PM
Herald added subscribers: riscv, olce, emaste, imp. · View Herald Transcript
mhorne requested review of this revision.May 23 2024, 7:15 PM
Harbormaster completed remote builds in B57872: Diff 139001.May 23 2024, 7:15 PM
markj accepted this revision.May 23 2024, 7:45 PM
This revision is now accepted and ready to land.May 23 2024, 7:45 PM
mhorne updated this revision to Diff 139445.Jun 4 2024, 5:17 PM

Remove the table argument too; this is a legacy interface that is now unused.

Current code is either provides a table explicitly via devmap_register_table(), or implicitly by the first call to devmap_add_entry().

This revision now requires review to proceed.Jun 4 2024, 5:17 PM
Harbormaster completed remote builds in B58054: Diff 139445.Jun 4 2024, 5:17 PM
mhorne retitled this revision from devmap: eliminate useless argument to devmap: eliminate unused arguments.Jun 4 2024, 5:27 PM
mhorne edited the summary of this revision. (Show Details)
andrew accepted this revision.Jun 4 2024, 5:33 PM
This revision is now accepted and ready to land.Jun 4 2024, 5:33 PM
markj accepted this revision.Jun 4 2024, 8:59 PM
Closed by commit rG5df74441b35f: devmap: eliminate unused arguments (authored by mhorne). · Explain WhyJun 4 2024, 11:20 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG5df74441b35f: devmap: eliminate unused arguments.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
2 lines
arm64/
arm64/
2 lines
kern/
17 lines
riscv/
riscv/
2 lines
sys/
7 lines

Diff 139445

View Options

sys/arm/arm/machdep.c

Loading...
View Options

sys/arm64/arm64/machdep.c

Loading...
View Options

sys/kern/subr_devmap.c

Loading...
View Options

sys/riscv/riscv/machdep.c

Loading...
View Options

sys/sys/devmap.h

Loading...