Page MenuHomeFreeBSD
Differential D45272

sound: Prevent uninitialized variable destruction in chn_init()
ClosedPublic
Actions

Authored by christos on May 20 2024, 2:03 PM.
Tags
None
Referenced Files
F101895627: D45272.id138786.diff
Tue, Nov 5, 8:17 AM
Unknown Object (File)
Mon, Oct 28, 4:23 AM
Unknown Object (File)
Fri, Oct 18, 9:17 AM
Unknown Object (File)
Thu, Oct 17, 8:56 AM
Unknown Object (File)
Thu, Oct 17, 8:41 AM
Unknown Object (File)
Wed, Oct 16, 1:04 AM
Unknown Object (File)
Tue, Oct 15, 8:55 PM
Unknown Object (File)
Tue, Oct 15, 6:03 PM
View All 65 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rGbca6f391aed9: sound: Prevent uninitialized variable destruction in chn_init()
rG5d1a5d6f1f59: sound: Prevent uninitialized variable destruction in chn_init()
Summary

If dsp_unit2name() fails, we'll get to out2 with b, bs and devinfo
uninitialized, which will result in a panic.

Reported by: Pierre Pronchery <pierre@freebsdfoundation.org>
Reported by: Coverity Scan
CID: 1545029, 1545025
Pull-request: https://github.com/freebsd/freebsd-src/pull/1240
Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.May 20 2024, 2:03 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 20 2024, 2:03 PM
christos requested review of this revision.May 20 2024, 2:03 PM
Harbormaster completed remote builds in B57790: Diff 138784.May 20 2024, 2:03 PM
markj accepted this revision.May 20 2024, 2:08 PM
markj added inline comments.
sys/dev/sound/pcm/channel.c
1252

These assignments are redundant since c was allocated with M_ZERO. You could just get rid of them.

This revision is now accepted and ready to land.May 20 2024, 2:08 PM
christos marked an inline comment as done.May 20 2024, 2:12 PM
christos added inline comments.
sys/dev/sound/pcm/channel.c
1252

D45273

christos updated this revision to Diff 138786.May 20 2024, 2:12 PM
christos marked an inline comment as done.

Address Mark's comment.

This revision now requires review to proceed.May 20 2024, 2:12 PM
Harbormaster completed remote builds in B57792: Diff 138786.May 20 2024, 2:12 PM
christos added a parent revision: D45273: sound: Get rid of redundant assignments in chn_init().May 20 2024, 2:12 PM
markj added inline comments.May 20 2024, 2:13 PM
sys/dev/sound/pcm/channel.c
1252

It should just be done in a single patch, IMHO, but ok.

emaste accepted this revision.May 20 2024, 2:15 PM
This revision is now accepted and ready to land.May 20 2024, 2:15 PM
Closed by commit rG5d1a5d6f1f59: sound: Prevent uninitialized variable destruction in chn_init() (authored by christos). · Explain WhyMay 20 2024, 2:15 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG5d1a5d6f1f59: sound: Prevent uninitialized variable destruction in chn_init().
christos added a commit: rGbca6f391aed9: sound: Prevent uninitialized variable destruction in chn_init().May 21 2024, 5:54 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
4 lines

Diff 138788

View Options

sys/dev/sound/pcm/channel.c

Loading...