HomeFreeBSD

pf: rework pf_icmp_state_lookup() failure mode

Description

pf: rework pf_icmp_state_lookup() failure mode

If pf_icmp_state_lookup() finds a state but rejects it for not matching the
expected direction we should unlock the state (and NULL out *state). This
simplifies life for callers, and also ensures there's no confusion about what a
non-NULL returned state means.

Previously it could have been left in there by the caller, resulting in callers
unlocking the same state twice.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Details

Provenance
kpAuthored on Fri, Aug 30, 11:36 AM
Parents
rG3da3eb6081a2: pf: be less strict about icmp state checking for sloppy state tracking
Branches
Unknown
Tags
Unknown