arm: fail early on gcc builds
ClosedPublic
Actions

Authored by brooks on May 14 2024, 12:11 AM.

Details

Reviewers

imp
jhb
andrew

Commits

rG4c0dfd5959bd: arm: fail early on gcc builds

Summary

Since at least 2022 (see https://reviews.freebsd.org/D36754), it has
not been possible to build armv6/armv7 with gcc due to atomics macros
gcc doesn't like. Prevent developers doing due diligance from wasting
time and CPU cycles on this combination as it just fails to build in
libc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.May 14 2024, 12:11 AM

Herald added a subscriber: emaste. · View Herald TranscriptMay 14 2024, 12:11 AM

brooks requested review of this revision.May 14 2024, 12:11 AM

Harbormaster completed remote builds in B57699: Diff 138513.May 14 2024, 12:11 AM

I'd be more inclined to land the other review, but until it does, this isn't bad.

This revision is now accepted and ready to land.May 14 2024, 6:31 PM

I have a few fixes for some of the build issues with gcc, but c++ bits of world and kernel modules are broken.

Makefile.inc1
180	I've seen more issues than that with gcc 13

Only amd64 and i386 successfully build with GCC currently. risc-v needs GCC's libatomic to link, powerpc and arm break in various ways. There's a reason that only amd64 GCC builds are enabled in CI. The toolchains do exist for all of our platforms, but getting things to build there is more of an aspiration.

Closed by commit rG4c0dfd5959bd: arm: fail early on gcc builds (authored by brooks). · Explain WhyMay 17 2024, 4:02 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG4c0dfd5959bd: arm: fail early on gcc builds.

Revision Contents
Changeset List

Path

Size

Makefile.inc1

7 lines

Diff 138655

View Options

arm: fail early on gcc buildsClosedPublicActions