Differential D45157

Increase IOAPIC_MAX_ID to 255 (from 254)
ClosedPublic
Actions

Authored by emaste on May 10 2024, 6:10 PM.

Tags

None

Referenced Files

	F115897197: D45157.diff
	Wed, Apr 30, 3:46 AM

	Unknown Object (File)
	Thu, Apr 24, 9:08 AM

	Unknown Object (File)
	Tue, Apr 22, 3:03 PM

	Unknown Object (File)
	Sat, Apr 19, 2:31 PM

	Unknown Object (File)
	Mar 30 2025, 8:34 PM

	Unknown Object (File)
	Feb 22 2025, 2:25 PM

	Unknown Object (File)
	Feb 22 2025, 1:52 PM

	Unknown Object (File)
	Feb 22 2025, 1:45 PM

View All 85 Files

Subscribers

Details

Reviewers

jhb
royger
kib

Commits

rGf952f27731ee: Increase IOAPIC_MAX_ID to 255 (from 254)
rG147c7e4dde23: Increase IOAPIC_MAX_ID to 255 (from 254)
rG18119e711f1c: Increase IOAPIC_MAX_ID to 255 (from 254)
rG4e3286818327: Increase IOAPIC_MAX_ID to 255 (from 254)

Summary

A test system here panicked with "madt_parse_apics: I/O APIC ID 255 too high". I/O APIC ID 255 is permissible.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.May 10 2024, 6:10 PM

emaste created this revision.

kib accepted this revision.May 10 2024, 6:16 PM

This revision is now accepted and ready to land.May 10 2024, 6:16 PM

Might want a comment or a detail in the commit log that while the 0xff ID is used for broadcast IPIs for local APICs when not using x2APIC, IPIs aren't sent to I/O APICs, so it's ok for an I/O APIC to reuse that ID. Might also want to note that I/O APIC IDs haven't been meaningful since the 3-wire APIC bus which was last used by systems using Pentium CPUs.

Add comment suggested by @jhb

This revision now requires review to proceed.May 10 2024, 7:30 PM

jhb accepted this revision.May 10 2024, 7:38 PM

This revision is now accepted and ready to land.May 10 2024, 7:38 PM

Closed by commit rG4e3286818327: Increase IOAPIC_MAX_ID to 255 (from 254) (authored by emaste). · Explain WhyMay 10 2024, 7:40 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG4e3286818327: Increase IOAPIC_MAX_ID to 255 (from 254).

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2024, 7:40 PM

emaste added a commit: rG18119e711f1c: Increase IOAPIC_MAX_ID to 255 (from 254).May 15 2024, 5:21 PM

emaste added a commit: rG147c7e4dde23: Increase IOAPIC_MAX_ID to 255 (from 254).May 16 2024, 12:23 PM

emaste added a commit: rGf952f27731ee: Increase IOAPIC_MAX_ID to 255 (from 254).May 27 2024, 3:41 PM

Revision Contents
Changeset List

Path

Size

sys/

x86/

include/

7 lines

Diff 138376

sys/x86/include/apicvar.h

Loading...