Page MenuHomeFreeBSD

Move support of Realtek 8156/8156B from cdce(4) to ure(4)
ClosedPublic

Authored by lwhsu on May 3 2024, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 6, 4:04 PM
Unknown Object (File)
Mon, Dec 23, 2:15 AM
Unknown Object (File)
Thu, Dec 12, 3:21 PM
Unknown Object (File)
Dec 2 2024, 1:17 PM
Unknown Object (File)
Nov 24 2024, 3:54 AM
Unknown Object (File)
Nov 24 2024, 3:52 AM
Unknown Object (File)
Nov 23 2024, 8:26 AM
Unknown Object (File)
Nov 19 2024, 2:58 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lwhsu requested review of this revision.May 3 2024, 10:16 PM

Mention 2500baseT in ure(4)

Only mention 8156/8156B in 2500baseT

I have an 8156 2.5G USB dongle that works great with ure(4) . +1 for this change.

Only mention 8156/8156B in 2500baseT

Please change 2500baseT to 2500Base-T, , the rest looks good, thanks.

This revision is now accepted and ready to land.Jul 6 2024, 7:32 AM

Rebase and address comments.

This revision now requires review to proceed.Aug 12 2024, 4:06 AM
This revision is now accepted and ready to land.Aug 12 2024, 5:47 AM

Sorry I'm late. I am extremely interested in consistency across the freebsd manual and will definitely test every manual review tagging @manpages, but I don't understand how to find them when that is omitted. Thanks!

https://github.com/freebsd/freebsd-src/pull/1384

share/man/man4/ure.4
31

Sorry I'm late (no tag @manpages?). Please don't hate me but:

This commit puts the apropos result for the ure driver at 86 columns, which wraps on a standard console. How's this:

.Nd RealTek RTL8152/RTL8153/RTL8156 USB Ethernet driver

The B variants can be omitted from the description for brevity, as they are in the page itself.
udav(4), mos(4), kue(4), cue(4), and axe(4) already use this language.

share/man/man4/ure.4
31

The B variants can be omitted from the description for brevity, as they are in the page itself.

s/are/should be like other ethernet driver manuals/

Sorry, I lost input field.

In D45088#1055876, @concussious.bugzilla_runbox.com wrote:

Sorry I'm late. I am extremely interested in consistency across the freebsd manual and will definitely test every manual review tagging @manpages, but I don't understand how to find them when that is omitted. Thanks!

https://github.com/freebsd/freebsd-src/pull/1384

Specifying chip variants is very important. Users could check the manual page to see whether the hardware they intend to purchase or already own is supported.

I agree, thus in the linked pull I added them with the others in the body of the description section around line 50s like the chips previously mentioned here.

I was not saying they were unimportant, but rather that the base name of the chip is a sufficient search keyword for the document description. The list of supported hardware is maintained in the body of the description section for all drivers.