The tests try to read kern.maxphys sysctl into int value, while
unsigned long is required. Not sure when this was broken, seems like
since cd8537910406e.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
u_long
tests/sys/fs/fusefs/write.cc | ||
---|---|---|
182 | This is getting close to a fence, and probably over it with custom maxphys setting. |
Comment Actions
The whole test set doesn't use this style, that's why I used unsigned long. I'd leave this decision to Alan.
tests/sys/fs/fusefs/write.cc | ||
---|---|---|
182 | What do you mean by "fence"? |
tests/sys/fs/fusefs/write.cc | ||
---|---|---|
182 | I mean that it is not too far from the default MAXPHYS value, and since maxphys is the dynamic boot parameter, user might cause the maxhphys to exceed m_maxwrite unknowingly. |