Stop using strerror() in printf*() guts
ClosedPublic
Actions

Authored by kib on Apr 23 2024, 5:18 PM.

Details

Reviewers

Commits

rGaa66995b4c80: libc printf_render_errno(): do not use strerror()
rGbac9d7e8f293: libc: minor style, wrap long lines
rGf88766769463: __vprintf(): switch from strerror() to strerror_rl()
rG92771bc00ad0: libc: make strerror_rl() usable for libc

Summary

PR: 278556

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Apr 23 2024, 5:18 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 23 2024, 5:18 PM

kib requested review of this revision.Apr 23 2024, 5:18 PM

I'd thought we didn't need to propogate the locale, since both strerror and strerror_r use the same locale()... but I'd forgotten printf can have a different one, so I proposed something different in the bug.
We could share buf and errormsg, but maybe it's not worth the hassle.

This revision is now accepted and ready to land.Apr 23 2024, 5:32 PM

Closed by commit rG92771bc00ad0: libc: make strerror_rl() usable for libc (authored by kib). · Explain WhyApr 23 2024, 7:44 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG92771bc00ad0: libc: make strerror_rl() usable for libc.

kib added a commit: rGf88766769463: __vprintf(): switch from strerror() to strerror_rl().

kib added a commit: rGbac9d7e8f293: libc: minor style, wrap long lines.

kib added a commit: rGaa66995b4c80: libc printf_render_errno(): do not use strerror().