Differential D44747

cloudware: allow disk format to be a list
ClosedPublic
Actions

Authored by bapt on Apr 11 2024, 11:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 22, 5:56 AM

	Unknown Object (File)
	Tue, Oct 22, 12:47 AM

	Unknown Object (File)
	Mon, Oct 21, 5:53 AM

	Unknown Object (File)
	Sun, Oct 13, 6:10 AM

	Unknown Object (File)
	Sun, Oct 13, 6:10 AM

	Unknown Object (File)
	Sun, Oct 13, 6:09 AM

	Unknown Object (File)
	Sun, Oct 13, 6:09 AM

	Unknown Object (File)
	Sun, Oct 13, 6:08 AM

View All 50 Files

Subscribers

Details

Reviewers

cperciva
emaste
allanjude

Group Reviewers

Commits

rG1c9953bea952: cloudware: allow disk format to be a list
rG5c213bf01a5d: cloudware: allow disk format to be a list
rG6ec9aaf63c81: cloudware: allow disk format to be a list

Summary

Make basic-cloudinit available both in qcow2 and raw formats

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57036
Build 53924: arc lint + arc unit

Event Timeline

bapt created this revision.Apr 11 2024, 11:42 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptApr 11 2024, 11:42 AM

bapt requested review of this revision.Apr 11 2024, 11:42 AM

Harbormaster completed remote builds in B57036: Diff 136887.Apr 11 2024, 11:42 AM

bapt added reviewers: releng, cperciva, emaste.Apr 11 2024, 11:43 AM

allanjude accepted this revision.Apr 11 2024, 1:55 PM

This revision is now accepted and ready to land.Apr 11 2024, 1:55 PM

Closed by commit rG6ec9aaf63c81: cloudware: allow disk format to be a list (authored by bapt). · Explain WhyApr 11 2024, 2:08 PM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG6ec9aaf63c81: cloudware: allow disk format to be a list.

bapt added a reverting change: rGeeec7a1199d0: Revert "cloudware: allow disk format to be a list".Apr 11 2024, 3:13 PM

cperciva reopened this revision.Apr 11 2024, 3:13 PM

cperciva added inline comments.

release/Makefile.vm
109	This needs to change, you're defining e.g. BASIC-CLOUDWAREUFSIMAGE twice.
118	And using the variable here which will probably result in both raw and qcow2 images being created with the name basic-cloudware.ufs.qcow2.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2024, 11:47 PM

Closed by commit rG5c213bf01a5d: cloudware: allow disk format to be a list (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG5c213bf01a5d: cloudware: allow disk format to be a list.

cperciva added a commit: rG1c9953bea952: cloudware: allow disk format to be a list.Apr 17 2024, 5:45 AM

Revision Contents
Changeset List

Path

Size

release/

30 lines

Diff 136887

release/Makefile.vm

Loading...