LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support

[cc]

Summary

This patch is based on D43648 and D44260.

PR: 277554,277416,277095
MFC after: 3 days
Sponsored by: The FreeBSD Foundation

Test Plan

My current AP only gives two keys: unicast and broadcast. Need discussion with
reviewers about why the hw key based on unicast key index does not work for
dhclient.

[adrian]

you negotiate it as an extension, and then it's used to switch STA keys without dropping frames.

Otherwise there's a window when you change STA keys where you'd have to stop traffic, flip the keys over, and then start traffic again, and that causes hiccups in traffic flows. Super annoying for low latency operations like VoIP.

[cc]

In D44463#1014016, @adrian wrote:

you negotiate it as an extension, and then it's used to switch STA keys without dropping frames.

During association with the AP, sw/hw keys (indexes) are set. And before tx, the hw key is selected by sw key's index returned from ieee80211_crypto_get_txkey(), same way as without LKPI_80211_HW_CRYPTO.

Would you please elaborate "you negotiate it as an extension"? I am not fully following up with your comment. I thought a frame only needs one key, as a key is selected every time the lkpi_80211_txq_tx_one() is called. Why would a frame need to switch STA keys?

[adrian]

sys/compat/linuxkpi/common/src/linux_80211.c

849

Should this be asserted/logged after the key alloc/set call? Since if the driver hasn't set this to anything you're gonna have big problems?

[cc]

rebase before scrutiny check

[bz]

sys/compat/linuxkpi/common/src/linux_80211.c

749

This should be no longer needed as of 0936c648ad0ee.

811

Similarly here.

[cc]

update based on bz@ comments