LinuxKPI: LKPI_80211_HW_CRYPTO: add crypto debug flag in LinuxKPI
Needs ReviewPublic
Actions

Authored by cc on Mar 6 2024, 10:27 PM.

Details

Reviewers

Summary

Also move the LKPI_80211_TRACE_MO to the same location.

PR: 277416
MFC after: 3 days

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56594
Build 53482: arc lint + arc unit

cc created this revision.Mar 6 2024, 10:27 PM

cc requested review of this revision.Mar 6 2024, 10:27 PM

bz requested changes to this revision.Mar 6 2024, 10:56 PM

bz added inline comments.

sys/compat/linuxkpi/common/src/linux_80211.c
559	That's an error message, not debug information
563	Error message, not debug information
589	Error message
592	Error message
sys/compat/linuxkpi/common/src/linux_80211.h
80	this part can probably just live in linux_80211.c and likely doesn't need all the per-cpu information but likely not much more than a TODO or IMPROVE or any other dumps?
sys/compat/linuxkpi/common/src/linux_80211_macops.c
38 ↗	(On Diff #135475)	Why do you need to move these? Are you envisioning MO tracing outside of this file?

This revision now requires changes to proceed.Mar 6 2024, 10:56 PM

cc added inline comments.Mar 7 2024, 1:08 PM

sys/compat/linuxkpi/common/src/linux_80211.c
559	Does not make much difference between unimplemented feature errors and debugging purposes. With `LKPI_80211_TRACE_CRYPTO`, it is organized under the same scope.
sys/compat/linuxkpi/common/src/linux_80211_macops.c
38 ↗	(On Diff #135475)	Put them in the same location is easier to read.