Page MenuHomeFreeBSD
Differential D44349

netinet/tcp_var.h: always define IS_FASTOPEN() for kernel compilation env
ClosedPublic
Actions

Authored by kib on Mar 13 2024, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 11:43 PM
Unknown Object (File)
Sat, Jan 4, 2:51 PM
Unknown Object (File)
Dec 4 2024, 4:47 AM
Unknown Object (File)
Oct 16 2024, 7:44 PM
Unknown Object (File)
Oct 16 2024, 7:44 PM
Unknown Object (File)
Oct 16 2024, 7:44 PM
Unknown Object (File)
Oct 16 2024, 7:20 PM
Unknown Object (File)
Sep 30 2024, 4:45 PM
View All 31 Files
Subscribers
imp
melifaro

Details

Reviewers
glebius
rscheff
Group Reviewers
transport
Commits
rG220ee18f1964: netinet/tcp_var.h: always define IS_FASTOPEN() for kernel compilation env
Summary
and drop the definition for userspace (which matched TCP_RFC7413) since
it depends on presence of the kernel option.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Mar 13 2024, 9:00 PM
Herald added a reviewer: transport. · View Herald TranscriptMar 13 2024, 9:00 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
kib requested review of this revision.Mar 13 2024, 9:00 PM
rscheff accepted this revision.Mar 13 2024, 9:13 PM
This revision is now accepted and ready to land.Mar 13 2024, 9:13 PM
glebius accepted this revision.Mar 13 2024, 11:15 PM

P.S. IMO, this is the kind of macros that create more obfuscation than clarity.

Closed by commit rG220ee18f1964: netinet/tcp_var.h: always define IS_FASTOPEN() for kernel compilation env (authored by kib). · Explain WhyMar 13 2024, 11:21 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG220ee18f1964: netinet/tcp_var.h: always define IS_FASTOPEN() for kernel compilation env.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines

Diff 135734

View Options

sys/netinet/tcp_var.h

Loading...