pci_host_generic: Simplify generic_pcie_translate_resource
ClosedPublic
Actions

Authored by jhb on Mar 4 2024, 10:44 PM.

Details

Reviewers

andrew
dch
tuexen

Commits

rG291079d0ebdd: pci_host_generic: Simplify generic_pcie_translate_resource

Summary

Inline generic_pcie_translate_resource_common into its sole caller.
No functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 4 2024, 10:44 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 4 2024, 10:44 PM

jhb requested review of this revision.Mar 4 2024, 10:44 PM

Harbormaster completed remote builds in B56427: Diff 135370.Mar 4 2024, 10:44 PM

jhb added a parent revision: D44205: pci_host_generic: Pass a valid end address in generic_pcie_translate_resource.Mar 4 2024, 10:44 PM

jhb added a child revision: D44207: pci_host_generic: Use SYS_RES_MEMORY for the parent of I/O resource ranges.

tuexen accepted this revision.Mar 4 2024, 11:05 PM

This revision is now accepted and ready to land.Mar 4 2024, 11:05 PM

@tuexen Would you be able to test this on your machine? I don't have an emag handy myself.

In D44206#1008545, @jhb wrote:

@tuexen Would you be able to test this on your machine? I don't have an emag handy myself.

I tested it. The machine comes up, the mce devices are there and can carry traffic...

Closed by commit rG291079d0ebdd: pci_host_generic: Simplify generic_pcie_translate_resource (authored by jhb). · Explain WhyMar 5 2024, 4:55 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG291079d0ebdd: pci_host_generic: Simplify generic_pcie_translate_resource.

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic.c

22 lines

Diff 135387

View Options

sys/dev/pci/pci_host_generic.c

pci_host_generic: Simplify generic_pcie_translate_resourceClosedPublicActions